Skip to content

sage: 8.4 -> 8.5 #51039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Dec 29, 2018
Merged

sage: 8.4 -> 8.5 #51039

merged 15 commits into from
Dec 29, 2018
+30 −953

Conversation

timokau
Copy link
Member

@timokau timokau commented Nov 25, 2018 •
edited
Loading

Motivation for this change

Tracking the upstream beta releases announced on sage-release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@timokau
sage: 8.4 -> 8.5.beta0

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
6138f5d
@timokau
sage: 8.5.beta0 -> 8.5.beta1
8e7da1b
@timokau
sage: add short tests
883aa99
@timokau
sage: 8.5.beta1 -> 8.5.beta2
3370247
@timokau
sage: 8.5.beta2 -> 8.5.beta3
2a87caa
@timokau
sage: 8.5.beta3 -> 8.5.beta4
90cebaf
@timokau
Copy link
Member Author

timokau commented Nov 25, 2018

@GrahamcOfBorg build sage.quicktest

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: sage.quicktest

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: sage.quicktest

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@timokau timokau added the 2.status: work-in-progress This PR isn't done label Nov 25, 2018
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 25, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: sage.quicktest

Partial log (click to expand)

    [0 tests, 0.00 s]
sage -t /nix/store/pvw21b4f480lsaip8iqza4k4iqmcc3az-python-2.7.15-env/lib/python2.7/site-packages/sagenb/notebook/worksheet.py
    [579 tests, 5.48 s]
----------------------------------------------------------------------
All tests passed!
----------------------------------------------------------------------
Total time for all tests: 558.1 seconds
    cpu time: 1630.1 seconds
    cumulative wall time: 1895.7 seconds
/nix/store/0a6y7l2bwskpfix5b9a9calx0svn54f6-sage-tests-8.5.beta4

@GrahamcOfBorg GrahamcOfBorg added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 11, 2018
@timokau
Copy link
Member Author

timokau commented Dec 23, 2018

@GrahamcOfBorg build sage.quicktest

@timokau
sage: 8.5.rc1 -> 8.5
6f0f06e
@timokau
sage: remove outdated patch files
360eddd
@timokau
Revert "sage: preload openblasCompat"
95909d4 
This reverts commit 4900bbe.

The issue that was supposed to fix is now fixed by lazy-loading rpy2 and
makign sure scipy is loaded before that.
That is not quite as nice, but preloading is now causing its own issues
with openblas 0.3.4:
OpenMathLib/OpenBLAS#1936
@timokau timokau removed the 2.status: work-in-progress This PR isn't done label Dec 28, 2018
@timokau
Copy link
Member Author

timokau commented Dec 28, 2018

@GrahamcOfBorg build sage.quicktest

@timokau timokau changed the title [WIP] sage: 8.4 -> 8.5 sage: 8.4 -> 8.5 Dec 28, 2018
@GrahamcOfBorg GrahamcOfBorg removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 28, 2018
@timokau timokau added the 2.status: work-in-progress This PR isn't done label Dec 28, 2018
@timokau
Copy link
Member Author

timokau commented Dec 29, 2018

@GrahamcOfBorg build sage.quicktest

@timokau
Copy link
Member Author

timokau commented Dec 29, 2018

Finally everything looks good. The openblas/cysignals issue (https://groups.google.com/forum/#!topic/sage-packaging/9N55B_JdXhc) was nasty to debug.

@timokau timokau merged commit 7abdacc into NixOS:master Dec 29, 2018
@timokau timokau deleted the sage-8.5 branch December 29, 2018 15:15
@timokau timokau removed the 2.status: work-in-progress This PR isn't done label Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @GrahamcOfBorg