Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crack-attack: enable custom sounds #51031

Merged
merged 1 commit into from Nov 25, 2018
Merged

crack-attack: enable custom sounds #51031

merged 1 commit into from Nov 25, 2018

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 25, 2018 •
edited

Motivation for this change

Closes #22905
crack-attack will search for user-provided musics and sounds
under ~/.crack-attack/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
crack-attack: enable custom sounds
bda40a2 
crack-attack will search for user-provided musics and sounds
under ~/.crack-attack/
@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 25, 2018

@GrahamcOfBorg build crack_attack

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: crack_attack

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
moving /nix/store/ia500nl9gxdnvj9nqp2szmmqp8djn69c-crack-attack-1.1.14/man to /nix/store/ia500nl9gxdnvj9nqp2szmmqp8djn69c-crack-attack-1.1.14/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/ia500nl9gxdnvj9nqp2szmmqp8djn69c-crack-attack-1.1.14
shrinking /nix/store/ia500nl9gxdnvj9nqp2szmmqp8djn69c-crack-attack-1.1.14/bin/crack-attack
gzipping man pages under /nix/store/ia500nl9gxdnvj9nqp2szmmqp8djn69c-crack-attack-1.1.14/share/man/
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ia500nl9gxdnvj9nqp2szmmqp8djn69c-crack-attack-1.1.14/bin
patching script interpreter paths in /nix/store/ia500nl9gxdnvj9nqp2szmmqp8djn69c-crack-attack-1.1.14
checking for references to /build in /nix/store/ia500nl9gxdnvj9nqp2szmmqp8djn69c-crack-attack-1.1.14...

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: crack_attack

Partial log (click to expand)

post-installation fixup
moving /nix/store/yvkcp6c9k4hgrpdipwp966bq5ll0ry9w-crack-attack-1.1.14/man to /nix/store/yvkcp6c9k4hgrpdipwp966bq5ll0ry9w-crack-attack-1.1.14/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/yvkcp6c9k4hgrpdipwp966bq5ll0ry9w-crack-attack-1.1.14
shrinking /nix/store/yvkcp6c9k4hgrpdipwp966bq5ll0ry9w-crack-attack-1.1.14/bin/crack-attack
gzipping man pages under /nix/store/yvkcp6c9k4hgrpdipwp966bq5ll0ry9w-crack-attack-1.1.14/share/man/
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/yvkcp6c9k4hgrpdipwp966bq5ll0ry9w-crack-attack-1.1.14/bin
patching script interpreter paths in /nix/store/yvkcp6c9k4hgrpdipwp966bq5ll0ry9w-crack-attack-1.1.14
checking for references to /build in /nix/store/yvkcp6c9k4hgrpdipwp966bq5ll0ry9w-crack-attack-1.1.14...
cannot link '/nix/store/.links/1qahg2vjahwq4wsswdaljwh39am5ddgpcwjrrrk2sxg0mg9pi0y6' to '/nix/store/yvkcp6c9k4hgrpdipwp966bq5ll0ry9w-crack-attack-1.1.14/share/crack-attack/sign_x10.tga': No space left on device

@c0bw3b c0bw3b merged commit ada29e4 into NixOS:master Nov 25, 2018
@c0bw3b c0bw3b deleted the pkg/crack-attack branch November 25, 2018 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@c0bw3b @GrahamcOfBorg