Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opencv4: init at 4.0.0 #51027

Merged
merged 1 commit into from Nov 30, 2018
Merged

opencv4: init at 4.0.0 #51027

merged 1 commit into from Nov 30, 2018

Conversation

basvandijk
Copy link
Member

Motivation for this change

https://github.com/opencv/opencv/wiki/ChangeLog#version400

Things done

The following succeeds:

nix-build -E \
  'let pkgs = import ./. {}; \
   in pkgs.opencv4.override { \
       enableIpp = true; \
       enableUnfree = true; \
       enablePython = true; \
       enableGtk3 = true; \
       enableVtk = true; \
       enableFfmpeg = true; \
       enableGStreamer = true; \
       enableTesseract = true; \
       enableTbb = true; \
       enableGPhoto2 = true; \
       enableDC1394 = true; \
       enableDocs = true;\
     }' 

If I enableOvis the build fails on https://github.com/opencv/opencv/issues/12851.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: opencv4

Partial log (click to expand)

shrinking /nix/store/bwsvw1kmrjafl2116cbwgimp8lyggd1b-opencv-4.0.0/lib/libopencv_ml.so.4.0.0
shrinking /nix/store/bwsvw1kmrjafl2116cbwgimp8lyggd1b-opencv-4.0.0/lib/libopencv_imgproc.so.4.0.0
shrinking /nix/store/bwsvw1kmrjafl2116cbwgimp8lyggd1b-opencv-4.0.0/lib/libopencv_hdf.so.4.0.0
shrinking /nix/store/bwsvw1kmrjafl2116cbwgimp8lyggd1b-opencv-4.0.0/lib/libopencv_flann.so.4.0.0
shrinking /nix/store/bwsvw1kmrjafl2116cbwgimp8lyggd1b-opencv-4.0.0/lib/libopencv_core.so.4.0.0
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bwsvw1kmrjafl2116cbwgimp8lyggd1b-opencv-4.0.0/lib  /nix/store/bwsvw1kmrjafl2116cbwgimp8lyggd1b-opencv-4.0.0/bin
patching script interpreter paths in /nix/store/bwsvw1kmrjafl2116cbwgimp8lyggd1b-opencv-4.0.0
/nix/store/bwsvw1kmrjafl2116cbwgimp8lyggd1b-opencv-4.0.0/bin/setup_vars_opencv4.sh: interpreter directive changed from "/bin/bash" to "/nix/store/n1kfdl37qpzh3xn6klbym1ay6xpxvmw1-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/bwsvw1kmrjafl2116cbwgimp8lyggd1b-opencv-4.0.0...

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: opencv4

Partial log (click to expand)

      objc-class-ref in cap_avfoundation_mac.mm.o
  "_OBJC_CLASS_$_NSURL", referenced from:
      objc-class-ref in cap_avfoundation_mac.mm.o
ld: symbol(s) not found for architecture x86_64
clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [modules/videoio/CMakeFiles/opencv_videoio.dir/build.make:193: lib/libopencv_videoio.4.0.0.dylib] Error 1
make[1]: *** [CMakeFiles/Makefile2:3485: modules/videoio/CMakeFiles/opencv_videoio.dir/all] Error 2
make: *** [Makefile:163: all] Error 2
builder for '/nix/store/679857lf8iay78pn2k1k6yzyna15dip7-opencv-4.0.0.drv' failed with exit code 2
error: build of '/nix/store/679857lf8iay78pn2k1k6yzyna15dip7-opencv-4.0.0.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: opencv4

Partial log (click to expand)

shrinking /nix/store/cbs8jd6imfvr19i0s17javjcnqv9qn8j-opencv-4.0.0/bin/opencv_version
shrinking /nix/store/cbs8jd6imfvr19i0s17javjcnqv9qn8j-opencv-4.0.0/bin/opencv_visualisation
shrinking /nix/store/cbs8jd6imfvr19i0s17javjcnqv9qn8j-opencv-4.0.0/bin/opencv_waldboost_detector
shrinking /nix/store/cbs8jd6imfvr19i0s17javjcnqv9qn8j-opencv-4.0.0/bin/opencv_annotation
shrinking /nix/store/cbs8jd6imfvr19i0s17javjcnqv9qn8j-opencv-4.0.0/bin/opencv_interactive-calibration
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cbs8jd6imfvr19i0s17javjcnqv9qn8j-opencv-4.0.0/lib  /nix/store/cbs8jd6imfvr19i0s17javjcnqv9qn8j-opencv-4.0.0/bin
patching script interpreter paths in /nix/store/cbs8jd6imfvr19i0s17javjcnqv9qn8j-opencv-4.0.0
/nix/store/cbs8jd6imfvr19i0s17javjcnqv9qn8j-opencv-4.0.0/bin/setup_vars_opencv4.sh: interpreter directive changed from "/bin/bash" to "/nix/store/n2hjbpkf4c0m48945ivxs3lmsczzw2rg-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/cbs8jd6imfvr19i0s17javjcnqv9qn8j-opencv-4.0.0...

Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for adding this! 👍

On a side note: do you know how to fix the broken Darwin build? I don't know enough about Nix on darwin, but in case we don't get this fixed, I'd temporarily disable darwin support in meta.platforms :)


, enableUnfree ? false
, enableIpp ? false
, enablePython ? false, pythonPackages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admittedly I'm not sure if that's a good idea. Python seems to be used often for such cases today and a full rebuild takes a certain amount of power and time and using Python is also one of the advertised ways of using opencv4 according the documentation.

Also, how is this supposed to be used? I'd love to see it possible to simply add opencv to a python environment to start hacking (but there's no build product in lib/pythonX.X).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ma27 thanks for reminding me to also have Python support. I forced-pushed a opencv4 attribute in python-packages.nix. Note that 4.0.0.nix is a copy of 3.0.0.nix so the way we handle Python is the same as with opencv3.

@basvandijk
Copy link
Member Author

@GrahamcOfBorg build pythonPackages.opencv4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pythonPackages.opencv4

Partial log (click to expand)

shrinking /nix/store/6wsxa3d7069rc35pjkrps3ilpxjsqciv-opencv-4.0.0/lib/libopencv_ml.so.4.0.0
shrinking /nix/store/6wsxa3d7069rc35pjkrps3ilpxjsqciv-opencv-4.0.0/lib/libopencv_imgproc.so.4.0.0
shrinking /nix/store/6wsxa3d7069rc35pjkrps3ilpxjsqciv-opencv-4.0.0/lib/libopencv_hdf.so.4.0.0
shrinking /nix/store/6wsxa3d7069rc35pjkrps3ilpxjsqciv-opencv-4.0.0/lib/libopencv_flann.so.4.0.0
shrinking /nix/store/6wsxa3d7069rc35pjkrps3ilpxjsqciv-opencv-4.0.0/lib/libopencv_core.so.4.0.0
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6wsxa3d7069rc35pjkrps3ilpxjsqciv-opencv-4.0.0/lib  /nix/store/6wsxa3d7069rc35pjkrps3ilpxjsqciv-opencv-4.0.0/bin
patching script interpreter paths in /nix/store/6wsxa3d7069rc35pjkrps3ilpxjsqciv-opencv-4.0.0
/nix/store/6wsxa3d7069rc35pjkrps3ilpxjsqciv-opencv-4.0.0/bin/setup_vars_opencv4.sh: interpreter directive changed from "/bin/bash" to "/nix/store/bpspdmsl0yys24gs70flsvcw3wcnl7lx-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/6wsxa3d7069rc35pjkrps3ilpxjsqciv-opencv-4.0.0...

@basvandijk
Copy link
Member Author

basvandijk commented Nov 26, 2018

@Ma27 thanks for the review. I've made some attempts at fixing the darwin build but failed so far.

So it looks like a linker issue:

[ 62%] Linking CXX shared library ../../lib/libopencv_videoio.dylib
Undefined symbols for architecture x86_64:
  "_OBJC_CLASS_$_NSData", referenced from:
      objc-class-ref in cap_avfoundation_mac.mm.o
  "_OBJC_CLASS_$_NSDate", referenced from:
      objc-class-ref in cap_avfoundation_mac.mm.o
  "_OBJC_CLASS_$_NSDictionary", referenced from:
      objc-class-ref in cap_avfoundation_mac.mm.o
  "_OBJC_CLASS_$_NSURL", referenced from:
      objc-class-ref in cap_avfoundation_mac.mm.o
ld: symbol(s) not found for architecture x86_64
clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [modules/videoio/CMakeFiles/opencv_videoio.dir/build.make:193: lib/libopencv_videoio.4.0.0.dylib] Error 1

Apparently NSData is part of the Foundation framework. I don't see -framework foundation anywhere in the opencv sources so I tried adding it to the makefile of the failing videoio module here. I also added foundation to the dependencies of 4.0.0.nix. Unfortunately that didn't fix the problem.

Instead of disabling darwin support I could try just disabling the videoio module on darwin.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pythonPackages.opencv4

Partial log (click to expand)

shrinking /nix/store/smxqhhlf1dsblfqsqgl34v7cpljg8krn-opencv-4.0.0/lib/libopencv_bgsegm.so.4.0.0
shrinking /nix/store/smxqhhlf1dsblfqsqgl34v7cpljg8krn-opencv-4.0.0/lib/libopencv_flann.so.4.0.0
shrinking /nix/store/smxqhhlf1dsblfqsqgl34v7cpljg8krn-opencv-4.0.0/lib/libopencv_hfs.so.4.0.0
shrinking /nix/store/smxqhhlf1dsblfqsqgl34v7cpljg8krn-opencv-4.0.0/lib/libopencv_text.so.4.0.0
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/smxqhhlf1dsblfqsqgl34v7cpljg8krn-opencv-4.0.0/lib  /nix/store/smxqhhlf1dsblfqsqgl34v7cpljg8krn-opencv-4.0.0/bin
patching script interpreter paths in /nix/store/smxqhhlf1dsblfqsqgl34v7cpljg8krn-opencv-4.0.0
/nix/store/smxqhhlf1dsblfqsqgl34v7cpljg8krn-opencv-4.0.0/bin/setup_vars_opencv4.sh: interpreter directive changed from "/bin/bash" to "/nix/store/yal8k8rgbaj8p9vi08q1kh21ls0ndq95-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/smxqhhlf1dsblfqsqgl34v7cpljg8krn-opencv-4.0.0...
cannot link '/nix/store/.links/03q0mlbzwaw3aj67irglx79rbnnfyzsq1zgh3kmghrl5hdaf3p8a' to '/nix/store/smxqhhlf1dsblfqsqgl34v7cpljg8krn-opencv-4.0.0/include/opencv4/opencv2/gapi/gcall.hpp': No space left on device

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: opencv4

Partial log (click to expand)

shrinking /nix/store/vjm5hivy29lb1p1jwbs3ap5fiba8fbx7-opencv-4.0.0/lib/libopencv_ml.so.4.0.0
shrinking /nix/store/vjm5hivy29lb1p1jwbs3ap5fiba8fbx7-opencv-4.0.0/lib/libopencv_imgproc.so.4.0.0
shrinking /nix/store/vjm5hivy29lb1p1jwbs3ap5fiba8fbx7-opencv-4.0.0/lib/libopencv_hdf.so.4.0.0
shrinking /nix/store/vjm5hivy29lb1p1jwbs3ap5fiba8fbx7-opencv-4.0.0/lib/libopencv_flann.so.4.0.0
shrinking /nix/store/vjm5hivy29lb1p1jwbs3ap5fiba8fbx7-opencv-4.0.0/lib/libopencv_core.so.4.0.0
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vjm5hivy29lb1p1jwbs3ap5fiba8fbx7-opencv-4.0.0/lib  /nix/store/vjm5hivy29lb1p1jwbs3ap5fiba8fbx7-opencv-4.0.0/bin
patching script interpreter paths in /nix/store/vjm5hivy29lb1p1jwbs3ap5fiba8fbx7-opencv-4.0.0
/nix/store/vjm5hivy29lb1p1jwbs3ap5fiba8fbx7-opencv-4.0.0/bin/setup_vars_opencv4.sh: interpreter directive changed from "/bin/bash" to "/nix/store/bpspdmsl0yys24gs70flsvcw3wcnl7lx-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/vjm5hivy29lb1p1jwbs3ap5fiba8fbx7-opencv-4.0.0...

@basvandijk
Copy link
Member Author

Also reported this upstream.

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: pythonPackages.opencv4

Partial log (click to expand)

cannot build derivation '/nix/store/r2dmvln4h2ci08r3ij00ph5q8asg2b9k-apple-framework-QuickTime.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/m508f73y9wnf4dnq67br7gl6lvrr0nl1-apple-framework-AppKit.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/lkgrp94wwk73v8qs9v79iywzg2s1xm9q-apple-framework-CoreMedia.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/qf06qks45y4q6h6bdrbcpvs9x4jzkgkv-apple-framework-Cocoa.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/s5gcykf60nagka4q38jkxsv337mf1bdd-apple-framework-CoreMediaIO.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/59spkff5a393qymsy0axirc5g2nklabm-apple-framework-MediaToolbox.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/dwsr3y8ij1blphzr9nl4vr1hf0nc8dsx-apple-framework-VideoToolbox.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/pwhs0hj9scn55y7gkcmdxm0irwvdcgd8-apple-framework-QTKit.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/d1rhs7msprbxinsia5pcwg522bxpbsij-opencv-4.0.0.drv': 22 dependencies couldn't be built
error: build of '/nix/store/d1rhs7msprbxinsia5pcwg522bxpbsij-opencv-4.0.0.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: opencv4

Partial log (click to expand)

shrinking /nix/store/8d3721blyyvs1z8vi8n8ji9m1kjdlgij-opencv-4.0.0/bin/opencv_version
shrinking /nix/store/8d3721blyyvs1z8vi8n8ji9m1kjdlgij-opencv-4.0.0/bin/opencv_visualisation
shrinking /nix/store/8d3721blyyvs1z8vi8n8ji9m1kjdlgij-opencv-4.0.0/bin/opencv_waldboost_detector
shrinking /nix/store/8d3721blyyvs1z8vi8n8ji9m1kjdlgij-opencv-4.0.0/bin/opencv_annotation
shrinking /nix/store/8d3721blyyvs1z8vi8n8ji9m1kjdlgij-opencv-4.0.0/bin/opencv_interactive-calibration
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8d3721blyyvs1z8vi8n8ji9m1kjdlgij-opencv-4.0.0/lib  /nix/store/8d3721blyyvs1z8vi8n8ji9m1kjdlgij-opencv-4.0.0/bin
patching script interpreter paths in /nix/store/8d3721blyyvs1z8vi8n8ji9m1kjdlgij-opencv-4.0.0
/nix/store/8d3721blyyvs1z8vi8n8ji9m1kjdlgij-opencv-4.0.0/bin/setup_vars_opencv4.sh: interpreter directive changed from "/bin/bash" to "/nix/store/yal8k8rgbaj8p9vi08q1kh21ls0ndq95-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/8d3721blyyvs1z8vi8n8ji9m1kjdlgij-opencv-4.0.0...

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: opencv4

Partial log (click to expand)

cannot build derivation '/nix/store/r2dmvln4h2ci08r3ij00ph5q8asg2b9k-apple-framework-QuickTime.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/m508f73y9wnf4dnq67br7gl6lvrr0nl1-apple-framework-AppKit.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/lkgrp94wwk73v8qs9v79iywzg2s1xm9q-apple-framework-CoreMedia.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/qf06qks45y4q6h6bdrbcpvs9x4jzkgkv-apple-framework-Cocoa.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/s5gcykf60nagka4q38jkxsv337mf1bdd-apple-framework-CoreMediaIO.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/59spkff5a393qymsy0axirc5g2nklabm-apple-framework-MediaToolbox.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/dwsr3y8ij1blphzr9nl4vr1hf0nc8dsx-apple-framework-VideoToolbox.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/pwhs0hj9scn55y7gkcmdxm0irwvdcgd8-apple-framework-QTKit.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/naj0blw0rvhjby77kb9ljarrxrgaki3g-opencv-4.0.0.drv': 20 dependencies couldn't be built
error: build of '/nix/store/naj0blw0rvhjby77kb9ljarrxrgaki3g-opencv-4.0.0.drv' failed

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/need-some-help-with-nix-for-macos/1151/7

@basvandijk
Copy link
Member Author

@GrahamcOfBorg build opencv4

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: opencv4

Partial log (click to expand)

Cannot nix-instantiate `opencv4' because:
error: while evaluating 'callPackageWith' at /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/lib/customisation.nix:108:35, called from /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/pkgs/top-level/all-packages.nix:11672:13:
while evaluating 'makeOverridable' at /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/lib/customisation.nix:67:24, called from /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/lib/customisation.nix:112:8:
anonymous function at /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/pkgs/development/libraries/opencv/4.x.nix:1:1 called without required argument 'cf-private', at /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/lib/customisation.nix:69:12

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: opencv4

Partial log (click to expand)

Cannot nix-instantiate `opencv4' because:
error: while evaluating 'callPackageWith' at /var/lib/gc-of-borg/nix-test-rs-19/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-19/lib/customisation.nix:108:35, called from /var/lib/gc-of-borg/nix-test-rs-19/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-19/pkgs/top-level/all-packages.nix:11672:13:
while evaluating 'makeOverridable' at /var/lib/gc-of-borg/nix-test-rs-19/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-19/lib/customisation.nix:67:24, called from /var/lib/gc-of-borg/nix-test-rs-19/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-19/lib/customisation.nix:112:8:
anonymous function at /var/lib/gc-of-borg/nix-test-rs-19/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-19/pkgs/development/libraries/opencv/4.x.nix:1:1 called without required argument 'cf-private', at /var/lib/gc-of-borg/nix-test-rs-19/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-19/lib/customisation.nix:69:12

@basvandijk
Copy link
Member Author

@GrahamcOfBorg build opencv4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: opencv4

Partial log (click to expand)

/nix/store/vjm5hivy29lb1p1jwbs3ap5fiba8fbx7-opencv-4.0.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: opencv4

Partial log (click to expand)

shrinking /nix/store/8d3721blyyvs1z8vi8n8ji9m1kjdlgij-opencv-4.0.0/lib/libopencv_bgsegm.so.4.0.0
shrinking /nix/store/8d3721blyyvs1z8vi8n8ji9m1kjdlgij-opencv-4.0.0/lib/libopencv_flann.so.4.0.0
shrinking /nix/store/8d3721blyyvs1z8vi8n8ji9m1kjdlgij-opencv-4.0.0/lib/libopencv_hfs.so.4.0.0
shrinking /nix/store/8d3721blyyvs1z8vi8n8ji9m1kjdlgij-opencv-4.0.0/lib/libopencv_text.so.4.0.0
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8d3721blyyvs1z8vi8n8ji9m1kjdlgij-opencv-4.0.0/lib  /nix/store/8d3721blyyvs1z8vi8n8ji9m1kjdlgij-opencv-4.0.0/bin
patching script interpreter paths in /nix/store/8d3721blyyvs1z8vi8n8ji9m1kjdlgij-opencv-4.0.0
/nix/store/8d3721blyyvs1z8vi8n8ji9m1kjdlgij-opencv-4.0.0/bin/setup_vars_opencv4.sh: interpreter directive changed from "/bin/bash" to "/nix/store/yal8k8rgbaj8p9vi08q1kh21ls0ndq95-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/8d3721blyyvs1z8vi8n8ji9m1kjdlgij-opencv-4.0.0...
cannot link '/nix/store/.links/03q0mlbzwaw3aj67irglx79rbnnfyzsq1zgh3kmghrl5hdaf3p8a' to '/nix/store/8d3721blyyvs1z8vi8n8ji9m1kjdlgij-opencv-4.0.0/include/opencv4/opencv2/gapi/gcall.hpp': No space left on device

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: opencv4

Partial log (click to expand)

/nix/store/8d3721blyyvs1z8vi8n8ji9m1kjdlgij-opencv-4.0.0

@basvandijk
Copy link
Member Author

Thanks to a great tip from @alyssais about cf-private my last force-push fixed the build failure on darwin (I just tested this on my Mac). Lets see if ofborg doesn't time out this time.

@basvandijk
Copy link
Member Author

@GrahamcOfBorg build opencv4

Testing a final change to the patching of lib/pkgconfig/opencv4.pc...

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: opencv4

Partial log (click to expand)

make[1]: *** [CMakeFiles/Makefile2:6594: modules/video/CMakeFiles/pch_Generate_opencv_video.dir/all] Error 2
[ 27%] Built target pch_Generate_opencv_core
[ 27%] Built target pch_Generate_opencv_stitching
[ 27%] Built target pch_Generate_opencv_ximgproc
[ 27%] Built target pch_Generate_opencv_flann
[ 27%] Built target carotene_objs
make[1]: *** [CMakeFiles/Makefile2:8205: modules/sfm/src/libmv/libmv/multiview/CMakeFiles/multiview.dir/all] Error 2
make: *** [Makefile:163: all] Error 2
builder for '/nix/store/jpnr6bkq6kn7zm7bvgdvqmlkfy7p4qxp-opencv-4.0.0.drv' failed with exit code 2
error: build of '/nix/store/jpnr6bkq6kn7zm7bvgdvqmlkfy7p4qxp-opencv-4.0.0.drv' failed

@Ma27
Copy link
Member

Ma27 commented Nov 26, 2018

@basvandijk I just tested the Python support with the following expression (I checked out your branch locally):

with import ./. { };
{
  env-py3 = python3.withPackages (ps: [ ps.opencv4 ]);
  env-py2 = python.withPackages (ps: [ ps.opencv4 ]);
}

The output path has a python directory (with a setup.py and a cv2 directory with the python bindings), but they are not usable, as there's no built Python artifact that can be used automatically (they usually live in lib/pythonX.X/site-packages).

Unfortunately I don't know the package well enough to provide a reliable approach for fixing this.

Apart from that the expressions seems fine, if Borg is happy, this should be mergeable soon. Thanks a lot for the work! 👍

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: opencv4

Partial log (click to expand)

shrinking /nix/store/sv393l47j8nwcw760inm90k5nv6182m6-opencv-4.0.0/lib/libopencv_ml.so.4.0.0
shrinking /nix/store/sv393l47j8nwcw760inm90k5nv6182m6-opencv-4.0.0/lib/libopencv_imgproc.so.4.0.0
shrinking /nix/store/sv393l47j8nwcw760inm90k5nv6182m6-opencv-4.0.0/lib/libopencv_hdf.so.4.0.0
shrinking /nix/store/sv393l47j8nwcw760inm90k5nv6182m6-opencv-4.0.0/lib/libopencv_flann.so.4.0.0
shrinking /nix/store/sv393l47j8nwcw760inm90k5nv6182m6-opencv-4.0.0/lib/libopencv_core.so.4.0.0
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sv393l47j8nwcw760inm90k5nv6182m6-opencv-4.0.0/lib  /nix/store/sv393l47j8nwcw760inm90k5nv6182m6-opencv-4.0.0/bin
patching script interpreter paths in /nix/store/sv393l47j8nwcw760inm90k5nv6182m6-opencv-4.0.0
/nix/store/sv393l47j8nwcw760inm90k5nv6182m6-opencv-4.0.0/bin/setup_vars_opencv4.sh: interpreter directive changed from "/bin/bash" to "/nix/store/bpspdmsl0yys24gs70flsvcw3wcnl7lx-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/sv393l47j8nwcw760inm90k5nv6182m6-opencv-4.0.0...

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: opencv4

Partial log (click to expand)

shrinking /nix/store/4l0gwflsw080gzmpn1wz0zrji036z7v9-opencv-4.0.0/lib/libopencv_bgsegm.so.4.0.0
shrinking /nix/store/4l0gwflsw080gzmpn1wz0zrji036z7v9-opencv-4.0.0/lib/libopencv_flann.so.4.0.0
shrinking /nix/store/4l0gwflsw080gzmpn1wz0zrji036z7v9-opencv-4.0.0/lib/libopencv_hfs.so.4.0.0
shrinking /nix/store/4l0gwflsw080gzmpn1wz0zrji036z7v9-opencv-4.0.0/lib/libopencv_text.so.4.0.0
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4l0gwflsw080gzmpn1wz0zrji036z7v9-opencv-4.0.0/lib  /nix/store/4l0gwflsw080gzmpn1wz0zrji036z7v9-opencv-4.0.0/bin
patching script interpreter paths in /nix/store/4l0gwflsw080gzmpn1wz0zrji036z7v9-opencv-4.0.0
/nix/store/4l0gwflsw080gzmpn1wz0zrji036z7v9-opencv-4.0.0/bin/setup_vars_opencv4.sh: interpreter directive changed from "/bin/bash" to "/nix/store/yal8k8rgbaj8p9vi08q1kh21ls0ndq95-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/4l0gwflsw080gzmpn1wz0zrji036z7v9-opencv-4.0.0...
cannot link '/nix/store/.links/03q0mlbzwaw3aj67irglx79rbnnfyzsq1zgh3kmghrl5hdaf3p8a' to '/nix/store/4l0gwflsw080gzmpn1wz0zrji036z7v9-opencv-4.0.0/include/opencv4/opencv2/gapi/gcall.hpp': No space left on device

@kalbasit
Copy link
Member

If I enableOvis the build fails on opencv/opencv#12851.

The issue has been fixed in opencv/opencv_contrib#1913, we should probably apply that as a patch.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: opencv4

Partial log (click to expand)

shrinking /nix/store/4l0gwflsw080gzmpn1wz0zrji036z7v9-opencv-4.0.0/bin/opencv_version
shrinking /nix/store/4l0gwflsw080gzmpn1wz0zrji036z7v9-opencv-4.0.0/bin/opencv_visualisation
shrinking /nix/store/4l0gwflsw080gzmpn1wz0zrji036z7v9-opencv-4.0.0/bin/opencv_waldboost_detector
shrinking /nix/store/4l0gwflsw080gzmpn1wz0zrji036z7v9-opencv-4.0.0/bin/opencv_annotation
shrinking /nix/store/4l0gwflsw080gzmpn1wz0zrji036z7v9-opencv-4.0.0/bin/opencv_interactive-calibration
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4l0gwflsw080gzmpn1wz0zrji036z7v9-opencv-4.0.0/lib  /nix/store/4l0gwflsw080gzmpn1wz0zrji036z7v9-opencv-4.0.0/bin
patching script interpreter paths in /nix/store/4l0gwflsw080gzmpn1wz0zrji036z7v9-opencv-4.0.0
/nix/store/4l0gwflsw080gzmpn1wz0zrji036z7v9-opencv-4.0.0/bin/setup_vars_opencv4.sh: interpreter directive changed from "/bin/bash" to "/nix/store/yal8k8rgbaj8p9vi08q1kh21ls0ndq95-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/4l0gwflsw080gzmpn1wz0zrji036z7v9-opencv-4.0.0...

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: opencv4

Partial log (click to expand)

cannot build derivation '/nix/store/r2dmvln4h2ci08r3ij00ph5q8asg2b9k-apple-framework-QuickTime.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/m508f73y9wnf4dnq67br7gl6lvrr0nl1-apple-framework-AppKit.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/lkgrp94wwk73v8qs9v79iywzg2s1xm9q-apple-framework-CoreMedia.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/qf06qks45y4q6h6bdrbcpvs9x4jzkgkv-apple-framework-Cocoa.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/s5gcykf60nagka4q38jkxsv337mf1bdd-apple-framework-CoreMediaIO.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/59spkff5a393qymsy0axirc5g2nklabm-apple-framework-MediaToolbox.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/dwsr3y8ij1blphzr9nl4vr1hf0nc8dsx-apple-framework-VideoToolbox.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/pwhs0hj9scn55y7gkcmdxm0irwvdcgd8-apple-framework-QTKit.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/cpa4lnm1p0a3kvyzji35f2xpqnw8zh2d-opencv-4.0.0.drv': 21 dependencies couldn't be built
error: build of '/nix/store/cpa4lnm1p0a3kvyzji35f2xpqnw8zh2d-opencv-4.0.0.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: opencv4

Partial log (click to expand)

cannot build derivation '/nix/store/r2dmvln4h2ci08r3ij00ph5q8asg2b9k-apple-framework-QuickTime.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/m508f73y9wnf4dnq67br7gl6lvrr0nl1-apple-framework-AppKit.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/lkgrp94wwk73v8qs9v79iywzg2s1xm9q-apple-framework-CoreMedia.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/qf06qks45y4q6h6bdrbcpvs9x4jzkgkv-apple-framework-Cocoa.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/s5gcykf60nagka4q38jkxsv337mf1bdd-apple-framework-CoreMediaIO.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/59spkff5a393qymsy0axirc5g2nklabm-apple-framework-MediaToolbox.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/dwsr3y8ij1blphzr9nl4vr1hf0nc8dsx-apple-framework-VideoToolbox.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/pwhs0hj9scn55y7gkcmdxm0irwvdcgd8-apple-framework-QTKit.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/cpa4lnm1p0a3kvyzji35f2xpqnw8zh2d-opencv-4.0.0.drv': 21 dependencies couldn't be built
error: build of '/nix/store/cpa4lnm1p0a3kvyzji35f2xpqnw8zh2d-opencv-4.0.0.drv' failed

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 26, 2018

Side note: @basvandijk no need to manually call the bot, since you are a trusted user for ofBorg a build job will start automatically every time you open a PR or push new commits to one of your PR.
It creates a duplicate build job if you call for the bot on top of it.

@basvandijk
Copy link
Member Author

@c0bw3b thanks for the heads up. I didn't know ofborg would rerun on forced pushes. Good to know.

@kalbasit I applied the fix for ovis.

@Ma27 I will look into the Python issue next.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: opencv4

Partial log (click to expand)

shrinking /nix/store/1mqs0r0xssjcixqk0r61k94qaxj7xmcl-opencv-4.0.0/lib/libopencv_flann.so.4.0.0
shrinking /nix/store/1mqs0r0xssjcixqk0r61k94qaxj7xmcl-opencv-4.0.0/lib/libopencv_hfs.so.4.0.0
shrinking /nix/store/1mqs0r0xssjcixqk0r61k94qaxj7xmcl-opencv-4.0.0/lib/libopencv_text.so.4.0.0
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1mqs0r0xssjcixqk0r61k94qaxj7xmcl-opencv-4.0.0/lib  /nix/store/1mqs0r0xssjcixqk0r61k94qaxj7xmcl-opencv-4.0.0/bin
patching script interpreter paths in /nix/store/1mqs0r0xssjcixqk0r61k94qaxj7xmcl-opencv-4.0.0
/nix/store/1mqs0r0xssjcixqk0r61k94qaxj7xmcl-opencv-4.0.0/bin/setup_vars_opencv4.sh: interpreter directive changed from "/bin/bash" to "/nix/store/yal8k8rgbaj8p9vi08q1kh21ls0ndq95-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/1mqs0r0xssjcixqk0r61k94qaxj7xmcl-opencv-4.0.0...
cannot link '/nix/store/.links/03q0mlbzwaw3aj67irglx79rbnnfyzsq1zgh3kmghrl5hdaf3p8a' to '/nix/store/1mqs0r0xssjcixqk0r61k94qaxj7xmcl-opencv-4.0.0/include/opencv4/opencv2/gapi/gcall.hpp': No space left on device
cannot link '/nix/store/.links/1h0d2mi65c1gz2ny83phzyy71kdjbgxmhn0zd2n98xa6phj6g03h' to '/nix/store/1mqs0r0xssjcixqk0r61k94qaxj7xmcl-opencv-4.0.0/lib/libopencv_face.so.4.0.0': No space left on device

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: opencv4

Partial log (click to expand)

shrinking /nix/store/z2x2bqafkn01df3k76sa96faxw8rj5jp-opencv-4.0.0/lib/libopencv_ml.so.4.0.0
shrinking /nix/store/z2x2bqafkn01df3k76sa96faxw8rj5jp-opencv-4.0.0/lib/libopencv_imgproc.so.4.0.0
shrinking /nix/store/z2x2bqafkn01df3k76sa96faxw8rj5jp-opencv-4.0.0/lib/libopencv_hdf.so.4.0.0
shrinking /nix/store/z2x2bqafkn01df3k76sa96faxw8rj5jp-opencv-4.0.0/lib/libopencv_flann.so.4.0.0
shrinking /nix/store/z2x2bqafkn01df3k76sa96faxw8rj5jp-opencv-4.0.0/lib/libopencv_core.so.4.0.0
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/z2x2bqafkn01df3k76sa96faxw8rj5jp-opencv-4.0.0/lib  /nix/store/z2x2bqafkn01df3k76sa96faxw8rj5jp-opencv-4.0.0/bin
patching script interpreter paths in /nix/store/z2x2bqafkn01df3k76sa96faxw8rj5jp-opencv-4.0.0
/nix/store/z2x2bqafkn01df3k76sa96faxw8rj5jp-opencv-4.0.0/bin/setup_vars_opencv4.sh: interpreter directive changed from "/bin/bash" to "/nix/store/bpspdmsl0yys24gs70flsvcw3wcnl7lx-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/z2x2bqafkn01df3k76sa96faxw8rj5jp-opencv-4.0.0...

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: opencv4

Partial log (click to expand)

cannot build derivation '/nix/store/r2dmvln4h2ci08r3ij00ph5q8asg2b9k-apple-framework-QuickTime.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/m508f73y9wnf4dnq67br7gl6lvrr0nl1-apple-framework-AppKit.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/lkgrp94wwk73v8qs9v79iywzg2s1xm9q-apple-framework-CoreMedia.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/qf06qks45y4q6h6bdrbcpvs9x4jzkgkv-apple-framework-Cocoa.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/s5gcykf60nagka4q38jkxsv337mf1bdd-apple-framework-CoreMediaIO.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/59spkff5a393qymsy0axirc5g2nklabm-apple-framework-MediaToolbox.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/dwsr3y8ij1blphzr9nl4vr1hf0nc8dsx-apple-framework-VideoToolbox.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/pwhs0hj9scn55y7gkcmdxm0irwvdcgd8-apple-framework-QTKit.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/plj86mjw80wz00is1baic04ikb6b3fyp-opencv-4.0.0.drv': 22 dependencies couldn't be built
error: build of '/nix/store/plj86mjw80wz00is1baic04ikb6b3fyp-opencv-4.0.0.drv' failed

@basvandijk
Copy link
Member Author

The following issue incl. potential work-around is relevant regarding the Python issue: opencv/opencv#13202

@Ma27
Copy link
Member

Ma27 commented Nov 27, 2018

Thanks a lot for the link, I only looked at the documentation :)

Does this result in building issues as well? In case this applies for OpenCV 4 as well, we could either comment the relevant parts out and wait for an upstream fix or add a warning during evaluatin (e.g. with builtins.trace that the Python bindings are currently broken).

@basvandijk
Copy link
Member Author

basvandijk commented Nov 28, 2018

Does this result in building issues as well?

The library builds successfully but the python bindings are in the wrong place.

Before disabling or adding warnings I would like to try out the suggestion in the linked issue that brings back the old behaviour:

  • OPENCV_SKIP_PYTHON_LOADER=ON
  • OPENCV_PYTHON3_INSTALL_PATH=...site/dist-packages location...

I have some time to work on this tomorrow evening.

@Ma27
Copy link
Member

Ma27 commented Nov 28, 2018

Before disabling or adding warnings I would like to try out the suggestion in the linked issue that brings back the old behaviour

That's even better! I mainly wanted to provide options what to do in case we don't get to fix it :)

@basvandijk
Copy link
Member Author

@Ma27 I fixed the Python issue. Lets see if ofborg agrees:

@GrahamcOfBorg build pythonPackages.opencv4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pythonPackages.opencv4

Partial log (click to expand)

shrinking /nix/store/jnkij9h6xflbdinqykwvplkbc0wyy1w5-opencv-4.0.0/lib/libopencv_ml.so.4.0.0
shrinking /nix/store/jnkij9h6xflbdinqykwvplkbc0wyy1w5-opencv-4.0.0/lib/libopencv_imgproc.so.4.0.0
shrinking /nix/store/jnkij9h6xflbdinqykwvplkbc0wyy1w5-opencv-4.0.0/lib/libopencv_hdf.so.4.0.0
shrinking /nix/store/jnkij9h6xflbdinqykwvplkbc0wyy1w5-opencv-4.0.0/lib/libopencv_flann.so.4.0.0
shrinking /nix/store/jnkij9h6xflbdinqykwvplkbc0wyy1w5-opencv-4.0.0/lib/libopencv_core.so.4.0.0
strip is /nix/store/bbla06nbjnpi55x9b3zm945vq1mf5fbh-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jnkij9h6xflbdinqykwvplkbc0wyy1w5-opencv-4.0.0/lib  /nix/store/jnkij9h6xflbdinqykwvplkbc0wyy1w5-opencv-4.0.0/bin
patching script interpreter paths in /nix/store/jnkij9h6xflbdinqykwvplkbc0wyy1w5-opencv-4.0.0
/nix/store/jnkij9h6xflbdinqykwvplkbc0wyy1w5-opencv-4.0.0/bin/setup_vars_opencv4.sh: interpreter directive changed from "/bin/bash" to "/nix/store/bsb6596kk4fp20hyl9yl55xwv1ax4b6s-bash-4.4-p23/bin/bash"
checking for references to /build/ in /nix/store/jnkij9h6xflbdinqykwvplkbc0wyy1w5-opencv-4.0.0...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: pythonPackages.opencv4

Partial log (click to expand)

/nix/store/9msi5540bszwfxhydmp6bnlpbxmfn7fv-opencv-4.0.0/lib/libopencv_text.4.0.0.dylib: fixing dylib
/nix/store/9msi5540bszwfxhydmp6bnlpbxmfn7fv-opencv-4.0.0/lib/libopencv_tracking.4.0.0.dylib: fixing dylib
/nix/store/9msi5540bszwfxhydmp6bnlpbxmfn7fv-opencv-4.0.0/lib/libopencv_video.4.0.0.dylib: fixing dylib
/nix/store/9msi5540bszwfxhydmp6bnlpbxmfn7fv-opencv-4.0.0/lib/libopencv_videoio.4.0.0.dylib: fixing dylib
/nix/store/9msi5540bszwfxhydmp6bnlpbxmfn7fv-opencv-4.0.0/lib/libopencv_videostab.4.0.0.dylib: fixing dylib
/nix/store/9msi5540bszwfxhydmp6bnlpbxmfn7fv-opencv-4.0.0/lib/libopencv_xfeatures2d.4.0.0.dylib: fixing dylib
/nix/store/9msi5540bszwfxhydmp6bnlpbxmfn7fv-opencv-4.0.0/lib/libopencv_ximgproc.4.0.0.dylib: fixing dylib
/nix/store/9msi5540bszwfxhydmp6bnlpbxmfn7fv-opencv-4.0.0/lib/libopencv_xobjdetect.4.0.0.dylib: fixing dylib
/nix/store/9msi5540bszwfxhydmp6bnlpbxmfn7fv-opencv-4.0.0/lib/libopencv_xphoto.4.0.0.dylib: fixing dylib
/nix/store/9msi5540bszwfxhydmp6bnlpbxmfn7fv-opencv-4.0.0

@basvandijk basvandijk merged commit 274e72a into NixOS:master Nov 30, 2018
@dtzWill dtzWill mentioned this pull request Dec 31, 2018
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants