-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opencv4: init at 4.0.0 #51027
opencv4: init at 4.0.0 #51027
Conversation
Success on aarch64-linux (full log) Attempted: opencv4 Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Attempted: opencv4 Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: opencv4 Partial log (click to expand)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for adding this! 👍
On a side note: do you know how to fix the broken Darwin build? I don't know enough about Nix on darwin, but in case we don't get this fixed, I'd temporarily disable darwin
support in meta.platforms
:)
|
||
, enableUnfree ? false | ||
, enableIpp ? false | ||
, enablePython ? false, pythonPackages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Admittedly I'm not sure if that's a good idea. Python seems to be used often for such cases today and a full rebuild takes a certain amount of power and time and using Python is also one of the advertised ways of using opencv4
according the documentation.
Also, how is this supposed to be used? I'd love to see it possible to simply add opencv
to a python environment to start hacking (but there's no build product in lib/pythonX.X
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
73f1af0
to
e631423
Compare
@GrahamcOfBorg build pythonPackages.opencv4 |
Success on aarch64-linux (full log) Attempted: pythonPackages.opencv4 Partial log (click to expand)
|
@Ma27 thanks for the review. I've made some attempts at fixing the darwin build but failed so far. So it looks like a linker issue:
Apparently Instead of disabling darwin support I could try just disabling the |
Success on x86_64-linux (full log) Attempted: pythonPackages.opencv4 Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: opencv4 Partial log (click to expand)
|
Also reported this upstream. |
Timed out, unknown build status on x86_64-darwin (full log) Attempted: pythonPackages.opencv4 Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: opencv4 Partial log (click to expand)
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: opencv4 Partial log (click to expand)
|
This pull request has been mentioned on Nix community. There might be relevant details there: https://discourse.nixos.org/t/need-some-help-with-nix-for-macos/1151/7 |
e631423
to
7377665
Compare
@GrahamcOfBorg build opencv4 |
No attempt on x86_64-linux (full log) The following builds were skipped because they don't evaluate on x86_64-linux: opencv4 Partial log (click to expand)
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: opencv4 Partial log (click to expand)
|
7377665
to
e34bcc6
Compare
@GrahamcOfBorg build opencv4 |
Success on aarch64-linux (full log) Attempted: opencv4 Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: opencv4 Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: opencv4 Partial log (click to expand)
|
Thanks to a great tip from @alyssais about |
e34bcc6
to
4e1c919
Compare
@GrahamcOfBorg build opencv4 Testing a final change to the patching of |
Failure on aarch64-linux (full log) Attempted: opencv4 Partial log (click to expand)
|
@basvandijk I just tested the Python support with the following expression (I checked out your branch locally): with import ./. { };
{
env-py3 = python3.withPackages (ps: [ ps.opencv4 ]);
env-py2 = python.withPackages (ps: [ ps.opencv4 ]);
} The output path has a python directory (with a setup.py and a Unfortunately I don't know the package well enough to provide a reliable approach for fixing this. Apart from that the expressions seems fine, if Borg is happy, this should be mergeable soon. Thanks a lot for the work! 👍 |
Success on aarch64-linux (full log) Attempted: opencv4 Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: opencv4 Partial log (click to expand)
|
The issue has been fixed in opencv/opencv_contrib#1913, we should probably apply that as a patch. |
Success on x86_64-linux (full log) Attempted: opencv4 Partial log (click to expand)
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: opencv4 Partial log (click to expand)
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: opencv4 Partial log (click to expand)
|
4e1c919
to
7b53d6e
Compare
Side note: @basvandijk no need to manually call the bot, since you are a trusted user for ofBorg a build job will start automatically every time you open a PR or push new commits to one of your PR. |
Success on x86_64-linux (full log) Attempted: opencv4 Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: opencv4 Partial log (click to expand)
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: opencv4 Partial log (click to expand)
|
The following issue incl. potential work-around is relevant regarding the Python issue: opencv/opencv#13202 |
Thanks a lot for the link, I only looked at the documentation :) Does this result in building issues as well? In case this applies for OpenCV 4 as well, we could either comment the relevant parts out and wait for an upstream fix or add a warning during evaluatin (e.g. with |
The library builds successfully but the python bindings are in the wrong place. Before disabling or adding warnings I would like to try out the suggestion in the linked issue that brings back the old behaviour:
I have some time to work on this tomorrow evening. |
That's even better! I mainly wanted to provide options what to do in case we don't get to fix it :) |
7b53d6e
to
2b87ed7
Compare
@Ma27 I fixed the Python issue. Lets see if ofborg agrees: @GrahamcOfBorg build pythonPackages.opencv4 |
Success on aarch64-linux (full log) Attempted: pythonPackages.opencv4 Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: pythonPackages.opencv4 Partial log (click to expand)
|
Motivation for this change
https://github.com/opencv/opencv/wiki/ChangeLog#version400
Things done
The following succeeds:
If I
enableOvis
the build fails on https://github.com/opencv/opencv/issues/12851.sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)