Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.effect: fix python3.7 build #51022

Merged
merged 1 commit into from Nov 25, 2018
Merged

pythonPackages.effect: fix python3.7 build #51022

merged 1 commit into from Nov 25, 2018

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Nov 25, 2018

Motivation for this change

Fixes #51017

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam requested a review from FRidh as a code owner November 25, 2018 10:49
@dotlambda dotlambda merged commit 21f6996 into NixOS:master Nov 25, 2018
@marsam marsam deleted the feature/fix-python-effect branch November 25, 2018 14:29
periklis pushed a commit to periklis/nixpkgs that referenced this pull request Nov 25, 2018
@marsam @periklis
pythonPackages.effect: fix python3.7 build (NixOS#51022)
f638985
periklis pushed a commit to periklis/nixpkgs that referenced this pull request Nov 25, 2018
@marsam @periklis
pythonPackages.effect: fix python3.7 build (NixOS#51022)
6537a20
periklis pushed a commit to periklis/nixpkgs that referenced this pull request Dec 1, 2018
@marsam @periklis
pythonPackages.effect: fix python3.7 build (NixOS#51022)
30aa51c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @dotlambda @GrahamcOfBorg