Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.sievelib: init at 1.1.1 #48817

Merged
merged 2 commits into from Nov 25, 2018
Merged

pythonPackages.sievelib: init at 1.1.1 #48817

merged 2 commits into from Nov 25, 2018

Conversation

leenaars
Copy link
Contributor

@leenaars leenaars commented Oct 22, 2018 •
edited

Motivation for this change

Useful library that implements various RFC's.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@leenaars leenaars requested a review from FRidh as a code owner October 22, 2018 09:55
costrouc
costrouc suggested changes Oct 22, 2018
View reviewed changes
pkgs/development/python-modules/sievelib/default.nix Outdated
@@ -0,0 +1,41 @@
{ stdenv, lib, isPy3k, buildPythonPackage, fetchPypi, fetchpatch, mock
Copy link
Member

@costrouc costrouc Oct 22, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isPy3k and stdenv are not used in derivation. no need to have as inputs

@leenaars
Copy link
Contributor Author

@costrouc : You were right, those were remnants that could be removed. They are gone now.

@costrouc
Copy link
Member

@GrahamcOfBorg build python3Packages.sievelib python2Packages.sievelib

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python3Packages.sievelib, python2Packages.sievelib

Partial log (click to expand)

test_vacationext_with_multiline (sievelib.tests.test_parser.ValidSyntaxes) ... ok
test_vacationext_with_single_mail_address (sievelib.tests.test_parser.ValidSyntaxes) ... ok
test_set_command (sievelib.tests.test_parser.VariablesCommands) ... ok
/nix/store/50r722fpsrddi18x7jfwddfyhgbi1200-python3.6-sievelib-1.1.1

/nix/store/linar9mzwjyy118v3fh5360d0xbp9wsf-python2.7-sievelib-1.1.1
----------------------------------------------------------------------
Ran 76 tests in 0.089s

OK

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3Packages.sievelib, python2Packages.sievelib

Partial log (click to expand)

test_vacationext_with_multiline (sievelib.tests.test_parser.ValidSyntaxes) ... ok
test_vacationext_with_single_mail_address (sievelib.tests.test_parser.ValidSyntaxes) ... ok
test_set_command (sievelib.tests.test_parser.VariablesCommands) ... ok

----------------------------------------------------------------------
Ran 76 tests in 0.169s

OK
/nix/store/zvi771z337sk1nv9bddmx18lvqvxaw3x-python3.6-sievelib-1.1.1
/nix/store/4xwlxdwv3gzk5dgcka6ljkmdzlfp4yhv-python2.7-sievelib-1.1.1

@leenaars
Copy link
Contributor Author

@costrouc: Are the edits I made okay?

@costrouc
Copy link
Member

Yeah it looks great to me. I don't have permissions to merge PRs. @FRidh would be the one to do that.

dotlambda
dotlambda requested changes Oct 29, 2018
View reviewed changes
pkgs/development/python-modules/sievelib/default.nix Outdated
* Date and Index (RFC 5260)
* Vacation (RFC 5230)
* Imap4flags (RFC 5232)
'';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the indentation.

pkgs/development/python-modules/sievelib/default.nix

patches = [
(fetchpatch {
url = "https://github.com/tonioo/sievelib/commit/1deef0e2bf039a0e817ea6f19aaf1947dc9fafbc.patch";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url = "https://github.com/tonioo/sievelib/commit/1deef0e2bf039a0e817ea6f19aaf1947dc9fafbc.patch";
url = "${meta.homepage}/commit/1deef0e2bf039a0e817ea6f19aaf1947dc9fafbc.patch";

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 25, 2018

@GrahamcOfBorg build python3Packages.sievelib python2Packages.sievelib

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python3Packages.sievelib, python2Packages.sievelib

Partial log (click to expand)

test_vacationext_medium (sievelib.tests.test_parser.ValidSyntaxes) ... ok
test_vacationext_with_limit (sievelib.tests.test_parser.ValidSyntaxes) ... ok
test_vacationext_with_multiline (sievelib.tests.test_parser.ValidSyntaxes) ... ok
test_vacationext_with_single_mail_address (sievelib.tests.test_parser.ValidSyntaxes) ... ok
test_set_command (sievelib.tests.test_parser.VariablesCommands) ... ok

----------------------------------------------------------------------
Ran 76 tests in 0.078s

OK

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3Packages.sievelib, python2Packages.sievelib

Partial log (click to expand)

Test renamescript command simulation. ... ok
/nix/store/cy83grz2iz0bm72b0jmmi4b152fz7k9v-python3.7-sievelib-1.1.1
test_setactive (sievelib.tests.test_managesieve.ManageSieveTestCase)
Test setactive command. ... ok

----------------------------------------------------------------------
Ran 76 tests in 0.044s

/nix/store/p037vcf9i5r78ic7fghvn8nb2534rg4l-python2.7-sievelib-1.1.1
OK

@c0bw3b c0bw3b merged commit f7b2518 into NixOS:master Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costrouc costrouc costrouc requested changes

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@leenaars @costrouc @GrahamcOfBorg @c0bw3b @dotlambda