PICARD-1371: Do not allow installation on 32-bit Windows #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on 64bit Win 10 and 32 bit Win 7 systems. |
|
This is the dialog shown on 32bit Windows:
|
zas
approved these changes
Nov 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently the Windows installer of Picard will happily install on a 32bit Windows, but since we only provide 64 bit builds the installed application fails to launch with some Windows incompatibility warning.
This patch checks if the installer is running on a 64bit system and if not aborts the installation with an appropriate error message.
Problem
Solution
Action