Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-zsh-completions: 0.4.0 -> 0.4.1 #51055

Merged
merged 1 commit into from Nov 26, 2018
Merged

nix-zsh-completions: 0.4.0 -> 0.4.1 #51055

merged 1 commit into from Nov 26, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Nov 26, 2018 •
edited

Motivation for this change

Contains several bugfixes that improve the ZSH completion for nix*
commands.

For further reference: https://github.com/spwhitt/nix-zsh-completions/releases/tag/0.4.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
nix-zsh-completions: 0.4.0 -> 0.4.1
e446261 
Contains several bugfixes that improve the ZSH completion for nix*
commands.

For further reference: https://github.com/spwhitt/nix-zsh-completions/releases/tag/0.4.1
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nix-zsh-completions

Partial log (click to expand)

no configure script, doing nothing
building
no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/05cxk94qvcn8jyrkjk5d3sgfkv5sf9p0-nix-zsh-completions-0.4.1
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/05cxk94qvcn8jyrkjk5d3sgfkv5sf9p0-nix-zsh-completions-0.4.1
checking for references to /build in /nix/store/05cxk94qvcn8jyrkjk5d3sgfkv5sf9p0-nix-zsh-completions-0.4.1...
/nix/store/05cxk94qvcn8jyrkjk5d3sgfkv5sf9p0-nix-zsh-completions-0.4.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nix-zsh-completions

Partial log (click to expand)

no configure script, doing nothing
building
no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wnq4hnhpv229rbgj60a4nsr0hr8ahcxw-nix-zsh-completions-0.4.1
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/wnq4hnhpv229rbgj60a4nsr0hr8ahcxw-nix-zsh-completions-0.4.1
checking for references to /build in /nix/store/wnq4hnhpv229rbgj60a4nsr0hr8ahcxw-nix-zsh-completions-0.4.1...
/nix/store/wnq4hnhpv229rbgj60a4nsr0hr8ahcxw-nix-zsh-completions-0.4.1

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: nix-zsh-completions

Partial log (click to expand)

cannot build derivation '/nix/store/06q1ps3hixaqrzg3269d7bf1abw63s7j-perl-5.28.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/wpkjxh4wh6mxrfjw3bl6d9q0gisc3p9g-pkg-config-0.29.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/qn4l72lrbp6kyzwlg75bxgk1bf2flgn1-unzip-6.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/7rmyhgfs3ncvjjvjgdc28y2yjwdbf4g1-openssl-1.0.2p.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/s2vsrh7jilzj1pam0rjxvx6f782xj6nr-libssh2-1.8.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/4r76k69xal3d4bri28xrggbyp8r17myp-nghttp2-1.34.0.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/cy4hwzbjkz08q3rkd9j4mdvb9razii47-curl-7.62.0.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/n4c2aw6r1qb7jjs93mnz3dg3slzjpljb-source.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/bp8c8yyy1pf4g5bkz8dzwgw0zigxbli8-nix-zsh-completions-0.4.1.drv': 2 dependencies couldn't be built
error: build of '/nix/store/bp8c8yyy1pf4g5bkz8dzwgw0zigxbli8-nix-zsh-completions-0.4.1.drv' failed

@Ma27
Copy link
Member Author

Ma27 commented Nov 26, 2018

Approval of another maintainer, tested locally, Darwin seems to require a rebuild as the build fails due to timed out dependencies, so this should be safe to merge.

@Ma27 Ma27 merged commit 2a17b5b into NixOS:master Nov 26, 2018
@Ma27 Ma27 deleted the bump-nix-zsh-completions branch November 26, 2018 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @GrahamcOfBorg @worldofpeace