Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.yattag: init at 1.10.1 #51056

Merged
merged 2 commits into from Nov 26, 2018
Merged

pythonPackages.yattag: init at 1.10.1 #51056

merged 2 commits into from Nov 26, 2018

Conversation

ryan4729
Copy link
Contributor

Motivation for this change

Adding an HTML generation library I'm using for a project

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions - gentoo with nix2.0.4
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ryan4729 ryan4729 requested a review from FRidh as a code owner November 26, 2018 00:33
Ma27
Ma27 requested changes Nov 26, 2018
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the missing license field in the meta section this seems fine.

pkgs/development/python-modules/yattag/default.nix
meta = with lib; {
description = "Generate HTML or XML in a pythonic way. Pure python alternative to web template engines. Can fill HTML forms with default values and error messages.";
homepage = http://www.yattag.org/;
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually want to have a license field in the meta section for documentation purposes and to prevent possible legal issues in certain setups.

Also, have you thought about adding yourself as maintainer to the package?

@Ma27
Copy link
Member

Ma27 commented Nov 26, 2018

@GrahamcOfBorg build pythonPackages.yattag python3Packages.yattag

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pythonPackages.yattag, python3Packages.yattag

Partial log (click to expand)

reading manifest file 'yattag.egg-info/SOURCES.txt'
writing manifest file 'yattag.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/simb719pll3rs8zr0lx0ni56d2ysc9cs-python2.7-yattag-1.10.1
/nix/store/375a8fmqx1f0nhs4xc85w1ql8lqniszx-python3.7-yattag-1.10.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pythonPackages.yattag, python3Packages.yattag

Partial log (click to expand)

reading manifest file 'yattag.egg-info/SOURCES.txt'
writing manifest file 'yattag.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/f516b01v3c81pw39w8sjv6zpv8dckkv0-python2.7-yattag-1.10.1
/nix/store/bvrvy25y2y25wdqbci8abx162yr95qkr-python3.7-yattag-1.10.1

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: pythonPackages.yattag, python3Packages.yattag

Partial log (click to expand)

cannot build derivation '/nix/store/2l0x0jp2qspmlbjlcp85n3bp7n7v93cq-python2.7-setuptools-40.4.3.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/pmvp1fpkkrcgcqwq4hpqayjrv4kqlqvm-ninja-1.8.2.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/13wjf36kwwhsz6ig52mpgqxynvsdzz07-python2.7-yattag-1.10.1.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/14g4mv488iib7w86ikhvvxd7b3pn13b5-swift-corefoundation.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/w0h8gaaxvpknn7wgiqs4axadv8s8p1m9-python3-3.7.1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/7nllncab6l92xzg41gqg7cgkl9m5vvlz-hook.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/mk3gifl82v1msww1wbsifn1k9cg40x2r-python3.7-bootstrapped-pip-18.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/48w4pqp5xlm9xg5r1vzin8arhgm8b735-python3.7-setuptools-40.4.3.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/s35m758ygfxpci7nwspmkdfj0jznca94-python3.7-yattag-1.10.1.drv': 4 dependencies couldn't be built
error: build of '/nix/store/13wjf36kwwhsz6ig52mpgqxynvsdzz07-python2.7-yattag-1.10.1.drv', '/nix/store/s35m758ygfxpci7nwspmkdfj0jznca94-python3.7-yattag-1.10.1.drv' failed

Ma27
Ma27 approved these changes Nov 26, 2018
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built locally and tested the package's functionality. As the license is now added and the package is fairly trivial (we don't have a hard rule for package maintainers) this seems legit to me 👍

@Ma27
Copy link
Member

Ma27 commented Nov 26, 2018

Also, the darwin failures seem to be related to not yet built dependencies (and thus build timeouts).

@Ma27 Ma27 merged commit 5095c08 into NixOS:master Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryan4729 @Ma27 @GrahamcOfBorg