Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appimage-run: fix missing libatk-bridge-2.0.so.0 #51060

Merged
merged 1 commit into from Dec 6, 2018
Merged

appimage-run: fix missing libatk-bridge-2.0.so.0 #51060

merged 1 commit into from Dec 6, 2018

Conversation

kamilchm
Copy link
Member

Motivation for this change

Fix error while loading shared libraries: libatk-bridge-2.0.so.0 when trying to run Beaker Browser >= 0.8.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kamilchm kamilchm mentioned this pull request Nov 26, 2018
Closed
@kamilchm
appimage-run: fix missing libatk-bridge-2.0.so.0
e7fd32d 
Fix `error while loading shared libraries: libatk-bridge-2.0.so.0`
when trying to run Beaker Browser >= 0.8.0
@worldofpeace
Copy link
Contributor

cc @tilpner

@tilpner
Copy link
Member

tilpner commented Nov 29, 2018

This is Probably Fine™, but we may want to check the library list against https://github.com/AppImage/AppImages/blob/master/excludelist in the future instead of adding what seems necessary.

@kamilchm
Copy link
Member Author

If this is Probably Fine then the library list is Probably missing it. I'm now more in doubt about this PR a lot more than when I was doing it.

@Ekleog
Copy link
Member

Ekleog commented Nov 29, 2018

@kamilchm My opinion is that if in ~a week you don't have a definitive answer in there, this can be merged. Upstream is broken in various ways and we already repair it, if we have more libraries than required by the AppImage “spec”, the only thing we'll miss will be a somewhat bigger closure. I just ran nix path-info -S $(nix-build --no-out-link . -A appimage-run, it goes from 1596207888 ~= 1596M to 1597100768 ~= 1597M… no big deal.

@tilpner
Copy link
Member

tilpner commented Dec 5, 2018

@fusion809 This one will add libatk-bridge to the defaults.

@worldofpeace
Copy link
Contributor

I guess we should go for it now 😄

@worldofpeace worldofpeace merged commit 904e185 into NixOS:master Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kamilchm @worldofpeace @tilpner @Ekleog @GrahamcOfBorg