Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [Win32] Align sprite glyphs to the font baseline when using Uniscribe text layout #6979

Merged
merged 1 commit into from Dec 1, 2018

Conversation

michicc
Copy link
Member

@michicc michicc commented Nov 25, 2018

Our sprite glyphs just look better when not stuck at the top of the line.

@michicc michicc added the OS: Windows This issue is related to a MS Windows problem label Nov 25, 2018
Copy link
Contributor

@nielsmh nielsmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work just fine with English, Arabic, Hebrew, Chinese (Simplified), and Japanese. That should cover all cases.

@michicc michicc merged commit 3b8db31 into OpenTTD:master Dec 1, 2018
@michicc michicc deleted the pr/fix_uniscribe_align branch December 1, 2018 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS: Windows This issue is related to a MS Windows problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants