Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.manuel: 1.8.0 -> 1.10.1 #51029

Merged
merged 1 commit into from Nov 26, 2018
Merged

pythonPackages.manuel: 1.8.0 -> 1.10.1 #51029

merged 1 commit into from Nov 26, 2018

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Nov 25, 2018

Motivation for this change

Fixes #51016

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam requested a review from FRidh as a code owner November 25, 2018 14:55
@Ma27
Copy link
Member

Ma27 commented Nov 26, 2018

@GrahamcOfBorg build pythonPackages.manuel python3Packages.manuel

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pythonPackages.manuel, python3Packages.manuel

Partial log (click to expand)

/build/manuel-1.10.1/src/manuel/capture.txt:Nested directives ... ok
/build/manuel-1.10.1/src/manuel/capture.txt:Error reporting
/build/manuel-1.10.1/src/manuel/capture.txt:Error reporting ... ok
turtle_on_the_bottom_test (manuel.tests)
Doctest: manuel.tests.turtle_on_the_bottom_test ... ok

----------------------------------------------------------------------
Ran 60 tests in 0.152s

OK

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pythonPackages.manuel, python3Packages.manuel

Partial log (click to expand)

/build/manuel-1.10.1/src/manuel/capture.txt:Nested directives ... ok
/build/manuel-1.10.1/src/manuel/capture.txt:Error reporting
/build/manuel-1.10.1/src/manuel/capture.txt:Error reporting ... ok
turtle_on_the_bottom_test (manuel.tests)
Doctest: manuel.tests.turtle_on_the_bottom_test ... ok

----------------------------------------------------------------------
Ran 60 tests in 0.298s

OK

@Ma27
Copy link
Member

Ma27 commented Nov 26, 2018

also running nix-review now as this change seems to impact several packages.

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: pythonPackages.manuel, python3Packages.manuel

Partial log (click to expand)

cannot build derivation '/nix/store/yz7adx42y0x935cwy3khhk3yd23g802y-python2.7-manuel-1.10.1.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/78sbhnfksgr73xqxlbfqsx0fd6bkmplr-python3.7-six-1.11.0.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/1hxazfkbpcj1dbgk3hdidjl5h5bqhl74-python3.7-zope.event-4.0.3.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/w8pqcfp0rmwjzhb54grrbiy5g1192anz-python3.7-zope.interface-4.5.0.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/90dc648878ldw631qp7nxnb7axgryn09-python3.7-zope.exceptions-4.0.8.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/9hc6snha5f0w69b145426wj0avbfwm8p-python3.7-zope.proxy-4.1.6.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/75ldgfj7yqm0zvy4llcn2mc035m53syg-python3.7-zope.location-4.0.3.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/zcr20772x60f92ha598qhz5l3yyk5bj2-python3.7-zope.testing-4.6.1.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/6q0vm3nw5qlxg070lpr2h16qf919ahlj-python3.7-manuel-1.10.1.drv': 8 dependencies couldn't be built
error: build of '/nix/store/6q0vm3nw5qlxg070lpr2h16qf919ahlj-python3.7-manuel-1.10.1.drv', '/nix/store/yz7adx42y0x935cwy3khhk3yd23g802y-python2.7-manuel-1.10.1.drv' failed

@Ma27
Copy link
Member

Ma27 commented Nov 26, 2018

Unfortunately the changes to the package break the following pacakges according to nix-review (you can test dependant packages using nix-review rev $your_revision_to_test):

11 package(s) failed to build:
i3pystatus python27Packages.praw python27Packages.prawcore python27Packages.scrapy python27Packages.testfixtures python27Packages.tokenserver python37Packages.praw python37Packages.prawcore python37Packages.scrapy python37Packages.sopel python37Packages.testfixtures

It would be great if you could check if those packages were broken because of the dependency bump :)

@dotlambda
Copy link
Member

These 11 packages also fail on master, so it's not due to this PR.

@dotlambda dotlambda merged commit 5229c87 into NixOS:master Nov 26, 2018
@marsam marsam deleted the feature/update-python-manuel branch November 26, 2018 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marsam @Ma27 @GrahamcOfBorg @dotlambda