Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildRustPackage: write cargo config to temporary file instead of source dir #51028

Closed
wants to merge 1 commit into from
Closed

buildRustPackage: write cargo config to temporary file instead of source dir #51028

wants to merge 1 commit into from

Conversation

clefru
Copy link
Contributor

@clefru clefru commented Nov 25, 2018

... as this fails if the source dir contains a "config" directory.

Motivation for this change

I want to build https://github.com/mimblewimble/grin/ which has a "config" dir.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@clefru
Write cargo config to temporary file instead of source dir.
8d4fbc5 
... as this fails if the source dir contains a "config" directory.
@Mic92
Copy link
Member

Mic92 commented Nov 26, 2018

@GrahamcOfBorg build fd

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: fd

Partial log (click to expand)

these paths will be fetched (0.77 MiB download, 2.62 MiB unpacked):
  /nix/store/z62n4sd4bfx3a6vjg3af5bgv8s5v9hvn-fd-7.2.0
copying path '/nix/store/z62n4sd4bfx3a6vjg3af5bgv8s5v9hvn-fd-7.2.0' from 'https://cache.nixos.org'...
/nix/store/z62n4sd4bfx3a6vjg3af5bgv8s5v9hvn-fd-7.2.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: fd

Partial log (click to expand)

these paths will be fetched (0.77 MiB download, 2.62 MiB unpacked):
  /nix/store/z62n4sd4bfx3a6vjg3af5bgv8s5v9hvn-fd-7.2.0
copying path '/nix/store/z62n4sd4bfx3a6vjg3af5bgv8s5v9hvn-fd-7.2.0' from 'https://cache.nixos.org'...
/nix/store/z62n4sd4bfx3a6vjg3af5bgv8s5v9hvn-fd-7.2.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: fd

Partial log (click to expand)

post-installation fixup
moving /nix/store/z3wzjfn1qrmw5g37zia16ss4i1173x95-fd-7.2.0/man to /nix/store/z3wzjfn1qrmw5g37zia16ss4i1173x95-fd-7.2.0/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/z3wzjfn1qrmw5g37zia16ss4i1173x95-fd-7.2.0
shrinking /nix/store/z3wzjfn1qrmw5g37zia16ss4i1173x95-fd-7.2.0/bin/fd
gzipping man pages under /nix/store/z3wzjfn1qrmw5g37zia16ss4i1173x95-fd-7.2.0/share/man/
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/z3wzjfn1qrmw5g37zia16ss4i1173x95-fd-7.2.0/bin
patching script interpreter paths in /nix/store/z3wzjfn1qrmw5g37zia16ss4i1173x95-fd-7.2.0
checking for references to /build in /nix/store/z3wzjfn1qrmw5g37zia16ss4i1173x95-fd-7.2.0...
/nix/store/z3wzjfn1qrmw5g37zia16ss4i1173x95-fd-7.2.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: fd

Partial log (click to expand)

these derivations will be built:
  /nix/store/bs0wg9cf456i1v04pjs5k52i5bxyry5f-fd-7.2.0.drv
waiting for locks or build slots...
/nix/store/z3wzjfn1qrmw5g37zia16ss4i1173x95-fd-7.2.0

@Mic92 Mic92 changed the title Write cargo config to temporary file instead of source dir. buildRustPackage: write cargo config to temporary file instead of source dir. Nov 26, 2018
@Mic92 Mic92 changed the title buildRustPackage: write cargo config to temporary file instead of source dir. buildRustPackage: write cargo config to temporary file instead of source dir Nov 26, 2018
@Mic92
Copy link
Member

Mic92 commented Nov 26, 2018

merged to staging: dc8aca4

@Mic92 Mic92 closed this Nov 26, 2018
Mic92 added a commit that referenced this pull request Nov 26, 2018
@Mic92
Merge pull request #51028 from clefru/tmp-cargo-config
dc8aca4 
buildRustPackage: write cargo config to temporary file instead of source dir
@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: fd

Partial log (click to expand)

cannot build derivation '/nix/store/kvihld40wj79li1kmf7dq8wjdig8ik2x-docbook2X-0.8.8.drv': 13 dependencies couldn't be built
cannot build derivation '/nix/store/af54z0kwggvwsfcxhvnv0cwgbjrz4ykn-apple-framework-Security.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/dm0k9xlb50pj15bk5x9gyhgs7w3792ya-git-2.19.1.drv': 22 dependencies couldn't be built
cannot build derivation '/nix/store/sv89ydx8axccrcp48mcwpqx56yd7774g-libgit2-0.26.8.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/5i65wj4b20dq7cz1449jq03a6j6djadv-rustc-bootstrap-1.29.2.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/68jb9jp8rzdm96881l27wkkz121pl68g-cargo-bootstrap-1.29.2.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/awxnkzy6ls7ki8s7n12bw1qf15hkc9lw-rustc-1.30.0.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/pn1d764lcjqmyy6hjick36yawify5pd3-cargo-1.30.0.drv': 16 dependencies couldn't be built
cannot build derivation '/nix/store/z8acgv73hfap909cxi4i12ydya4xf664-fd-7.2.0.drv': 5 dependencies couldn't be built
error: build of '/nix/store/z8acgv73hfap909cxi4i12ydya4xf664-fd-7.2.0.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: fd

Partial log (click to expand)

cannot build derivation '/nix/store/kvihld40wj79li1kmf7dq8wjdig8ik2x-docbook2X-0.8.8.drv': 13 dependencies couldn't be built
cannot build derivation '/nix/store/af54z0kwggvwsfcxhvnv0cwgbjrz4ykn-apple-framework-Security.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/dm0k9xlb50pj15bk5x9gyhgs7w3792ya-git-2.19.1.drv': 22 dependencies couldn't be built
cannot build derivation '/nix/store/sv89ydx8axccrcp48mcwpqx56yd7774g-libgit2-0.26.8.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/5i65wj4b20dq7cz1449jq03a6j6djadv-rustc-bootstrap-1.29.2.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/68jb9jp8rzdm96881l27wkkz121pl68g-cargo-bootstrap-1.29.2.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/awxnkzy6ls7ki8s7n12bw1qf15hkc9lw-rustc-1.30.0.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/pn1d764lcjqmyy6hjick36yawify5pd3-cargo-1.30.0.drv': 16 dependencies couldn't be built
cannot build derivation '/nix/store/z8acgv73hfap909cxi4i12ydya4xf664-fd-7.2.0.drv': 5 dependencies couldn't be built
error: build of '/nix/store/z8acgv73hfap909cxi4i12ydya4xf664-fd-7.2.0.drv' failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clefru @Mic92 @GrahamcOfBorg