Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/urxvtd: remove socket activation #51043

Merged
merged 1 commit into from Nov 28, 2018
Merged

nixos/urxvtd: remove socket activation #51043

merged 1 commit into from Nov 28, 2018

Conversation

fishyfriend
Copy link
Contributor

@fishyfriend fishyfriend commented Nov 25, 2018 •
edited

This fixes #23193, urxvtd service doesn't work first time by removing systemd socket activation.

Motivation for this change

urxvtd is not compatible with systemd's socket activation feature. When it starts up, it replaces the systemd-created socket with its own, causing a connected urxvtc client to hang. See this comment for a more detailed explanation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fishyfriend
nixos/urxvtd: remove socket activation
b34b39c 
This fixes #23193. urxvtd is not presently compatible with socket activation.
@fishyfriend fishyfriend mentioned this pull request Nov 25, 2018
Closed
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Nov 25, 2018

FInally someone figured it out. Thank you.
I'm a bit disappointed that the socket activation must be removed, though.
This probably should be reported upstream.

@fishyfriend
Copy link
Contributor Author

@rnhmjoj I will inquire with the upstream project. It seems like a pretty easy thing to fix.

@Ekleog
Copy link
Member

Ekleog commented Nov 28, 2018 •
edited

@fishyfriend Nice catch, thank you! Could you consider opening a backport PR with a cherry-pick of this PR's commit against release-18.09? The problem appears to be present there too.

The procedure for cherry-picking is git cherry-pick -x [your commit], so that the reference to the cherry-picked commit is kept in the new commit.

@Ekleog Ekleog merged commit b34b39c into NixOS:master Nov 28, 2018
@fishyfriend fishyfriend mentioned this pull request Nov 30, 2018
Merged
10 tasks
@fishyfriend
Copy link
Contributor Author

@Ekleog Thanks for the suggestion, done: #51299

@fishyfriend
Copy link
Contributor Author

I have submitted a patch on the rxvt-unicode mailing list to add socket activation to urxvtd.

@Ekleog
Copy link
Member

Ekleog commented Dec 1, 2018

Great, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

urxvtd service doesn't work first time
5 participants
@fishyfriend @rnhmjoj @Ekleog @GrahamcOfBorg @Janik-Haag