Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pew: fix build #51051

Merged
merged 2 commits into from Nov 26, 2018
Merged

pew: fix build #51051

merged 2 commits into from Nov 26, 2018

Conversation

alyssais
Copy link
Member

Motivation for this change

#51034

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I had a quick go at getting the tests to run, but they didn't seem to work out of the box, and it's out of the scope of getting the build working anyway.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pew

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
warning: no previously-included files matching '*~' found under directory 'pew'
writing manifest file 'pew.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/f3377ag4m9lxpv9payliwf2c7hnbjl4j-pew-1.1.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pew

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
warning: no previously-included files matching '*~' found under directory 'pew'
writing manifest file 'pew.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/cwix3h6n1lxyjrh3l5lz2v90l5aykqyf-pew-1.1.2

worldofpeace
worldofpeace suggested changes Nov 26, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll need glibcLocales as a buildInputs also.

@Mic92
Copy link
Member

Mic92 commented Nov 26, 2018

@GrahamcOfBorg build pew

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pew

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
warning: no previously-included files matching '*~' found under directory 'pew'
writing manifest file 'pew.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/cwix3h6n1lxyjrh3l5lz2v90l5aykqyf-pew-1.1.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pew

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
warning: no previously-included files matching '*~' found under directory 'pew'
writing manifest file 'pew.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/f3377ag4m9lxpv9payliwf2c7hnbjl4j-pew-1.1.2

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: pew

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
warning: no previously-included files matching '*~' found under directory 'pew'
writing manifest file 'pew.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/3f4509q6was8bah3ryjlfaqqs08kvagi-pew-1.1.2

@Mic92 Mic92 merged commit 7e88234 into NixOS:master Nov 26, 2018
@Mic92
Copy link
Member

Mic92 commented Nov 26, 2018

does not seem to be required in this case.

@alyssais alyssais deleted the pew branch November 26, 2018 09:33
@alyssais alyssais mentioned this pull request Nov 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alyssais @GrahamcOfBorg @Mic92 @worldofpeace