Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove confuse (duplicate) and pommed (obsolete) #51036

Merged
merged 2 commits into from Nov 25, 2018
Merged

Remove confuse (duplicate) and pommed (obsolete) #51036

merged 2 commits into from Nov 25, 2018

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 25, 2018 •
edited

Motivation for this change

Some cleanup:

  • confuse is a duplicate of libconfuse -> keep the latter which respects upstream name and is up-to-date ;
  • replaced confuse with libconfuse in all packages depending on it
  • pommed is removed entirely since it's obsolete since before 16.03

See commit messages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
confuse: remove and replace with libconfuse
9762e2c 
- confuse is a duplicate of libconfuse
- upstream name is libconfuse so keep this one
- replace confuse with libconfuse in packages depending on it
@c0bw3b
pommed: remove
47c2739 
- homepage / source / patch are all gone
- marked as broken since 16.03
- pommed module already relies on pommed_light
@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 25, 2018

@GrahamcOfBorg build tilda i3status libftdi1 pommed_light

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tilda, i3status, libftdi1

The following builds were skipped because they don't evaluate on aarch64-linux: pommed_light

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/x980bsrjw6c43k0h965rbqz60pbhh2vm-tilda-1.4.1
shrinking /nix/store/x980bsrjw6c43k0h965rbqz60pbhh2vm-tilda-1.4.1/bin/wrapped/tilda
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/x980bsrjw6c43k0h965rbqz60pbhh2vm-tilda-1.4.1/bin
patching script interpreter paths in /nix/store/x980bsrjw6c43k0h965rbqz60pbhh2vm-tilda-1.4.1
checking for references to /build in /nix/store/x980bsrjw6c43k0h965rbqz60pbhh2vm-tilda-1.4.1...
/nix/store/x980bsrjw6c43k0h965rbqz60pbhh2vm-tilda-1.4.1
/nix/store/cpjikdms6p7hhyf3mkjg4mzb6zr34wav-i3status-2.12
/nix/store/g26qskibcb5gykj2n8jwrnh32ybv9siy-libftdi1-1.4

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tilda, i3status, libftdi1, pommed_light

Partial log (click to expand)

strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/clg6npj6xpdcba2zi4gx7n0aili96dzc-libftdi1-1.4/lib  /nix/store/clg6npj6xpdcba2zi4gx7n0aili96dzc-libftdi1-1.4/lib64  /nix/store/clg6npj6xpdcba2zi4gx7n0aili96dzc-libftdi1-1.4/bin
patching script interpreter paths in /nix/store/clg6npj6xpdcba2zi4gx7n0aili96dzc-libftdi1-1.4
/nix/store/clg6npj6xpdcba2zi4gx7n0aili96dzc-libftdi1-1.4/bin/libftdi1-config: interpreter directive changed from "/bin/sh" to "/nix/store/n2hjbpkf4c0m48945ivxs3lmsczzw2rg-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/clg6npj6xpdcba2zi4gx7n0aili96dzc-libftdi1-1.4...
moving /nix/store/clg6npj6xpdcba2zi4gx7n0aili96dzc-libftdi1-1.4/lib64/* to /nix/store/clg6npj6xpdcba2zi4gx7n0aili96dzc-libftdi1-1.4/lib
/nix/store/l19c28q647l2n4wh1bmk5b8v7a2f1fj9-tilda-1.4.1
/nix/store/fzqvn8wk51yicrwrjawsimxvxgamkd1x-i3status-2.12
/nix/store/clg6npj6xpdcba2zi4gx7n0aili96dzc-libftdi1-1.4
/nix/store/j66lhzxgbwkg8nbcnyhnwz3nqpi9122k-pommed-light-1.51lw

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 25, 2018

@GrahamcOfBorg build udisks_glue dispad bmon xbursttools

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: udisks_glue, dispad, bmon

The following builds were skipped because they don't evaluate on aarch64-linux: xbursttools

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/v59w78aa7ysq92w0mvzjpifhgvqgkz9p-bmon-4.0
shrinking /nix/store/v59w78aa7ysq92w0mvzjpifhgvqgkz9p-bmon-4.0/bin/bmon
gzipping man pages under /nix/store/v59w78aa7ysq92w0mvzjpifhgvqgkz9p-bmon-4.0/share/man/
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/v59w78aa7ysq92w0mvzjpifhgvqgkz9p-bmon-4.0/bin
patching script interpreter paths in /nix/store/v59w78aa7ysq92w0mvzjpifhgvqgkz9p-bmon-4.0
checking for references to /build in /nix/store/v59w78aa7ysq92w0mvzjpifhgvqgkz9p-bmon-4.0...
/nix/store/2s46flj18wfb0iz2lz5y6zamq76a7hxp-udisks-glue-1.3.5
/nix/store/j28210q571h4rqbr9dhsa4qi75snxiwj-dispad-0.3.1
/nix/store/v59w78aa7ysq92w0mvzjpifhgvqgkz9p-bmon-4.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: udisks_glue, dispad, bmon, xbursttools

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/v3piqj6myiqwfr9jq00sp8dq5vqi1rba-xburst-tools-2011-12-26
shrinking /nix/store/v3piqj6myiqwfr9jq00sp8dq5vqi1rba-xburst-tools-2011-12-26/bin/xbboot
shrinking /nix/store/v3piqj6myiqwfr9jq00sp8dq5vqi1rba-xburst-tools-2011-12-26/bin/usbboot
shrinking /nix/store/v3piqj6myiqwfr9jq00sp8dq5vqi1rba-xburst-tools-2011-12-26/bin/jzboot
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/v3piqj6myiqwfr9jq00sp8dq5vqi1rba-xburst-tools-2011-12-26/bin
mipsel-unknown-linux-uclibc-strip is /nix/store/5pwkb222mnyqrc3i7kpl1fadsxz19igc-mipsel-unknown-linux-uclibc-binutils-2.30/bin/mipsel-unknown-linux-uclibc-strip
stripping (with command mipsel-unknown-linux-uclibc-strip and flags -S) in /nix/store/v3piqj6myiqwfr9jq00sp8dq5vqi1rba-xburst-tools-2011-12-26/bin
patching script interpreter paths in /nix/store/v3piqj6myiqwfr9jq00sp8dq5vqi1rba-xburst-tools-2011-12-26
checking for references to /build in /nix/store/v3piqj6myiqwfr9jq00sp8dq5vqi1rba-xburst-tools-2011-12-26...

@c0bw3b c0bw3b merged commit c720866 into NixOS:master Nov 25, 2018
@c0bw3b c0bw3b deleted the cleanup/confuse branch December 6, 2018 20:05
@c0bw3b c0bw3b added this to To do in Picking up garbage via automation May 10, 2019
@c0bw3b c0bw3b moved this from To do to Done in Picking up garbage May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
Picking up garbage
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@c0bw3b @GrahamcOfBorg