Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btrfs-progs: 4.19 -> 4.19.1 #51638

Merged
merged 1 commit into from Dec 6, 2018

Conversation

spencerjanssen
Copy link
Contributor

Motivation for this change

Snapper fails to build with btrfs-progs 4.19. See openSUSE/snapper#459 and https://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg82954.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests). Ran nixos/tests/snapper.nix
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Fixes build of snapper
@markuskowa
Copy link
Member

@GrahamcOfBorg build snapper

@markuskowa
Copy link
Member

@markuskowa
Copy link
Member

@GrahamcOfBorg build nixosTests.snapper

@markuskowa
Copy link
Member

Looks good. Thank you.

@markuskowa markuskowa merged commit 3776a9e into NixOS:master Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants