Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish AdaptiveStepParameters and GeneralizedAdaptiveStepParameters in name only #2013

Merged
merged 20 commits into from
Dec 8, 2018

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Dec 6, 2018

This is purely restructuring supposedly without any semantic changes. It contributes to #1931.

@pleroy pleroy changed the title Distinguish AdaptiveStepParameters and AdaptiveStepParameters in name only Distinguish AdaptiveStepParameters and GeneralizedAdaptiveStepParameters in name only Dec 6, 2018
ksp_plugin::Barycentric>::AdaptiveStepParameters;
PHYSICS_DLL_TEMPLATE_CLASS
internal_ephemeris::Ephemeris<
ksp_plugin::Barycentric>::GeneralizedAdaptiveStepParameters;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AdaptiveStepParameters isn't a template class yet, I don't think this will work.

@eggrobin eggrobin added the LGTM label Dec 6, 2018
@pleroy
Copy link
Member Author

pleroy commented Dec 7, 2018

Retest this please

@pleroy pleroy merged commit 8985a9c into mockingbirdnest:master Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants