Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization of the Fine integrator #2010

Merged
merged 3 commits into from
Dec 6, 2018
Merged

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Dec 6, 2018

Another contribution to #1931.

@@ -92,6 +90,71 @@ SprkAsSrknDeserializer<ODE, Method, true>::ReadFromMessage(
}
}

template<typename RightHandSideComputation>
struct AdaptiveStepSizeIntegratorDeserializer;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invest in a comment here explaining that the RightHandSideComputation determines the type of the integrator when the method may be used for several kinds of integrators (this may not hold in general as we add more integrators, and is certainly not obvious).

@eggrobin eggrobin added the LGTM label Dec 6, 2018
@pleroy pleroy merged commit 30ff554 into mockingbirdnest:master Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants