cyrus-sasl: Remove private libs from .la files (fixes spice build) #51651
Conversation
|
@GrahamcOfBorg build spice |
|
@GrahamcOfBorg build cyrus_sasl |
| @@ -44,6 +39,7 @@ stdenv.mkDerivation rec { | |||
| postInstall = '' | |||
| for f in $out/lib/*.la $out/lib/sasl2/*.la; do | |||
| substituteInPlace $f --replace "${openssl.dev}/lib" "${openssl.out}/lib" | |||
| sed -i $f -e 's,-lresolv\|-lgssapi_krb5\|-lkrb5\|-lk5crypto\|-lcom_err,,g' | |||
There was a problem hiding this comment.
Took it form the libsasl2.pc, where they're all listed as private libraries. Might be wrong though.
There was a problem hiding this comment.
They're all added to the .la files, without the necessary -L flags.
There was a problem hiding this comment.
It comes from here:
https://github.com/cyrusimap/cyrus-sasl/blob/master/m4/sasl2.m4#L121
I would say there are two options: Either put kerberos in propagatedBuildInputs or disable kerberos for cyrus-sasl (maybe enabling via flags would work too).
There was a problem hiding this comment.
I am surprised though that you can just drop the libraries without having any missing symbols during linking.
There was a problem hiding this comment.
I'm fine with either alternative, though I'm not using this derivation myself, so cc @eburimu who did the upgrade to 2.1.27.
I guess downgrading is also an option, the release is very fresh while the previous release is many years old.
There was a problem hiding this comment.
Just wanted to mention that the commit that added pruneLibtoolFiles setup hook has some very useful notes on how to handle .la files - fd97db4
There was a problem hiding this comment.
Ok. So adding pruneLibtoolFiles should be safe in our case. The derivation only contains shared libraries.
Version 2.1.27 adds `-lkrb5` etc. to `dependency_libs` in all the .la files, which in turn breaks spice's build. Prune .la's dependency_libs with pruneLibtoolFiles.
|
Switched to |
since pruneLibtoolFiles is used openssl is no longer referenced
|
It is unnecessary, I checked it. |
cyrus_sasl: merge PR #51651 into master
Motivation for this change
Version 2.1.27 added the private libs to a bunch of .la files, which in turn
broke spice's build, #51444 (comment)
A cleaner approach would be to just remove the .la files, but I'm unsure if
that will break anything else.
cc #51444
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)