Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

passExtensions.pass-genphrase: init at 0.1 #51631

Merged
merged 1 commit into from Dec 6, 2018
Merged

passExtensions.pass-genphrase: init at 0.1 #51631

merged 1 commit into from Dec 6, 2018

Conversation

seqizz
Copy link
Contributor

@seqizz seqizz commented Dec 6, 2018

Motivation for this change

Genphrase extension generates memorable passwords (like this xkcd example)

Please check it though, this is my first contribution and I am sure you can find a lot of errors.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

rasendubi
rasendubi reviewed Dec 6, 2018
View reviewed changes
Copy link
Member

@rasendubi rasendubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit name could be

passExtensions.pass-genphrase: init at 0.1

Besides some minor comments, this looks good to me.

pkgs/tools/security/pass/extensions/genphrase.nix Outdated Show resolved Hide resolved
pkgs/tools/security/pass/extensions/genphrase.nix Outdated Show resolved Hide resolved
pkgs/tools/security/pass/extensions/genphrase.nix Outdated Show resolved Hide resolved
@seqizz
Copy link
Contributor Author

seqizz commented Dec 6, 2018

Thanks for the review & sorry for the rookie copy-paste. Should be ok now.

@seqizz seqizz changed the title pass: Add genphrase extension passExtensions.pass-genphrase: init at 0.1 Dec 6, 2018
@rasendubi
Copy link
Member

@GrahamcOfBorg build passExtensions.pass-genphrase

@rasendubi rasendubi merged commit cc8deff into NixOS:master Dec 6, 2018
@rasendubi
Copy link
Member

@seqizz thanks for your contribution and welcome to NixPkgs! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasendubi rasendubi rasendubi approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@seqizz @rasendubi @GrahamcOfBorg @Janik-Haag