Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux build fixes attempt 2 #2012

Closed

Conversation

madman2003
Copy link

I can see the impression I left with attempt 1. This time I've done my best not to break anything in your workflow, if it still happens it is truly is an accident.

I've tried to make something half decent of the commit history, it may not be a 100% perfect.

My reasons for doing this are because I want to see what I can about the principia UI, which as a user is far too tiny. Hence i need it to build for me.

P.S. the new geopotential method has problems with real solar system, it asserts on the Vesta celestial body, i will try to write up a more detailed bug report about that

@pleroy
Copy link
Member

pleroy commented Dec 6, 2018

Can one of the admins verify this patch?

@madman2003
Copy link
Author

@pleroy GeodesyTest.LAGEOS2 test fails, is that expected?

@madman2003
Copy link
Author

As promised: #2014

@madman2003
Copy link
Author

#2014 is indeed gone, but can someone at least confirm it was the potato roids that have no gravity field (and is that the case for all of them?)

Oh, and the LAGEOS2 test case still fails FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants