Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc: 7.3 -> 7.4 #51633

Closed
wants to merge 1 commit into from
Closed

gcc: 7.3 -> 7.4 #51633

wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 6, 2018

https://gcc.gnu.org/gcc-7/changes.html

Motivation for this change
Things done

I'm still testing this for various configurations, so far so good :).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Dec 7, 2018

Hmm, internal compiler error when building LLVM 7?

:(

@dtzWill dtzWill closed this Dec 7, 2018
@dtzWill dtzWill deleted the update/gcc-7.4.0 branch December 7, 2018 01:56
@vcunat
Copy link
Member

vcunat commented Dec 9, 2018

Any updates? I merged this with a staging commit (ee77dd6) and llvm+clang 7 built fine for me (x86_64 NixOS).

@dtzWill dtzWill restored the update/gcc-7.4.0 branch December 29, 2018 21:35
@dtzWill
Copy link
Member Author

dtzWill commented Dec 29, 2018

Any updates? I merged this with a staging commit (ee77dd6) and llvm+clang 7 built fine for me (x86_64 NixOS).

Interesting! I tried this myself, and it worked for me as well (rebased onto recent staging, same idea).

Let's revisit this, will update with rebased version in a few-- first for sake of sanity and curiosity investigating the issue a bit :).

@dtzWill
Copy link
Member Author

dtzWill commented Dec 29, 2018

Nevermind, tagging it for my own curiosity-- reopening with updated version.

@dtzWill dtzWill mentioned this pull request Dec 30, 2018
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @vcunat @GrahamcOfBorg