Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vivaldi: correct hash #51646

Merged
merged 1 commit into from Dec 7, 2018
Merged

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Fixes #51635

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
Copy link
Contributor

flokli commented Dec 7, 2018

@worldofpeace thanks! just to make sure, the current version and hash on 18.09 is fine and not broken?

@worldofpeace
Copy link
Contributor Author

@worldofpeace thanks! just to make sure, the current version and hash on 18.09 is fine and not broken?

Should be fine since Vivaldi in 18.09 is at 1.15.1147.42-1 and master is at 2.1.1337.51-1.
Though I think we should be backporting any browser updates for security.

@worldofpeace worldofpeace deleted the vivaldi/correct-hash branch December 7, 2018 09:03
@flokli
Copy link
Contributor

flokli commented Dec 7, 2018

Does Vivaldi provide some sort of changelog, so we know there's no current open security our current 1.15.x version?

Do they even consider 1.15.x a "stable branch", that's receiving any updates?

If they don't, we should bump 18.09 too 2.1.x, too…

@worldofpeace
Copy link
Contributor Author

It's chromium based so all chromium security issues effect Vivaldi. So backporting is needed.

Do they even consider 1.15.x a "stable branch", that's receiving any updates?

If you look at the url, on master, we're at the stable release.

@flokli
Copy link
Contributor

flokli commented Dec 7, 2018

It's chromium based so all chromium security issues effect Vivaldi. So backporting is needed.

Yes, but there's no listing of versions released, to see which version adresses a CVE / bumps chromium etc.

Do they even consider 1.15.x a "stable branch", that's receiving any updates?

If you look at the url, on master, we're at the stable release.

The 1.15.x version from 18.09 uses the same URL pattern, so there was a major version bump on their stable branch, and we should bump to that version on 18.09 as well.

@worldofpeace Can you prepare a PR for that?

@worldofpeace
Copy link
Contributor Author

Yes, but there's no listing of versions released, to see which version adresses a CVE / bumps chromium etc.

Just to know for the future, the changelog can be seen at https://update.vivaldi.com/update/X.x/relnotes/Major.minor.build.html

Here's the most recent one https://update.vivaldi.com/update/1.0/relnotes/2.1.1337.51.html

The 1.15.x version from 18.09 uses the same URL pattern, so there was a major version bump on their stable branch, and we should bump to that version on 18.09 as well.
@worldofpeace Can you prepare a PR for that?

Of course 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants