Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pylint: 2.1.1 -> 2.2.2 #51634

Merged
merged 2 commits into from Dec 7, 2018
Merged

pylint: 2.1.1 -> 2.2.2 #51634

merged 2 commits into from Dec 7, 2018

Conversation

jokogr
Copy link
Contributor

@jokogr jokogr commented Dec 6, 2018

Motivation for this change

pylint was failing some tests in master and thought to update it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jokogr jokogr requested a review from FRidh as a code owner December 6, 2018 20:14
@flokli flokli merged commit b89978c into NixOS:master Dec 7, 2018
@flokli
Copy link
Contributor

flokli commented Dec 7, 2018

from nox-review, /nix/store/pxvwqagvn5vk3bpjgfgwygqmgqqsdr4m-python3.7-pyside-shiboken-1.2.4.drv (for that reason, spyder) seems to be broken too.

@jokogr
Copy link
Contributor Author

jokogr commented Dec 7, 2018

@flokli I am sorry, I did not run nox-review. Unless anyone else makes a PR, I promise to deal with that later today.

@jokogr jokogr deleted the u/pylint-2.2.2 branch December 7, 2018 09:35
@flokli
Copy link
Contributor

flokli commented Dec 7, 2018

@jokogr no worries, it was already broken before - thanks a lot for fixing it!

@jokogr jokogr mentioned this pull request Dec 8, 2018
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jokogr @flokli @GrahamcOfBorg