Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trojita: build translation files #50697

Merged
merged 1 commit into from Nov 19, 2018
Merged

trojita: build translation files #50697

merged 1 commit into from Nov 19, 2018

Conversation

erosennin
Copy link
Contributor

Motivation for this change

Enable localization of Trojitá.

  • Use the release tarball, because translation files are not included in the git repository.

  • Add qttools needed for compiling translation files.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Nov 19, 2018

@GrahamcOfBorg build trojita

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: trojita

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: trojita

Partial log (click to expand)

shrinking /nix/store/2wjz1j2xl0iyzwdknsp83n5pz2qq7gl7-trojita-0.7/bin/be.contacts
shrinking /nix/store/2wjz1j2xl0iyzwdknsp83n5pz2qq7gl7-trojita-0.7/bin/trojita
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2wjz1j2xl0iyzwdknsp83n5pz2qq7gl7-trojita-0.7/lib  /nix/store/2wjz1j2xl0iyzwdknsp83n5pz2qq7gl7-trojita-0.7/bin
patching script interpreter paths in /nix/store/2wjz1j2xl0iyzwdknsp83n5pz2qq7gl7-trojita-0.7
checking for references to /build in /nix/store/2wjz1j2xl0iyzwdknsp83n5pz2qq7gl7-trojita-0.7...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/2wjz1j2xl0iyzwdknsp83n5pz2qq7gl7-trojita-0.7

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: trojita

Partial log (click to expand)

shrinking /nix/store/m6748wphnfxn5p67zxgcv8q8s0y8qk1j-trojita-0.7/bin/be.contacts
shrinking /nix/store/m6748wphnfxn5p67zxgcv8q8s0y8qk1j-trojita-0.7/lib/libtrojita_plugins.so
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/m6748wphnfxn5p67zxgcv8q8s0y8qk1j-trojita-0.7/lib  /nix/store/m6748wphnfxn5p67zxgcv8q8s0y8qk1j-trojita-0.7/bin
patching script interpreter paths in /nix/store/m6748wphnfxn5p67zxgcv8q8s0y8qk1j-trojita-0.7
checking for references to /build in /nix/store/m6748wphnfxn5p67zxgcv8q8s0y8qk1j-trojita-0.7...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/m6748wphnfxn5p67zxgcv8q8s0y8qk1j-trojita-0.7

@c0bw3b c0bw3b merged commit e49c389 into NixOS:master Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@erosennin @Mic92 @GrahamcOfBorg @c0bw3b