Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makemkv: 1.14.0 -> 1.14.1 #50696

Merged
merged 2 commits into from Nov 20, 2018
Merged

makemkv: 1.14.0 -> 1.14.1 #50696

merged 2 commits into from Nov 20, 2018

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Nov 19, 2018 •
edited

Motivation for this change

Previous URL is unreachable

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

c0bw3b
c0bw3b requested changes Nov 19, 2018
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was #50437 already
Same remarks apply : it needs two URLs for both files to avoid breaking at every minor bump..

@nyanloutre
makemkv: using two URLs for src
05166dc 
This will prevent future failures due to the first URL being broken each
time a new version is released

See NixOS#50437 (comment)
for details
@nyanloutre
Copy link
Member Author

@c0bw3b I just pushed a fix

@c0bw3b c0bw3b merged commit 032c4b9 into NixOS:master Nov 20, 2018
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 20, 2018

@nyanloutre thank you for this

@c0bw3b c0bw3b mentioned this pull request Nov 20, 2018
Closed
9 tasks
@nyanloutre nyanloutre deleted the makemkv-update branch November 20, 2018 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nyanloutre @c0bw3b @GrahamcOfBorg