Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pymssql: init at 2.1.4 #50699

Merged
merged 1 commit into from Nov 23, 2018
Merged

pymssql: init at 2.1.4 #50699

merged 1 commit into from Nov 23, 2018

Conversation

mredaelli
Copy link
Contributor

Motivation for this change

Missing package from python collection

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Nov 19, 2018

@GrahamcOfBorg build python2.pkgs.pymssql python3.pkgs.pymssql

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.pymssql, python3.pkgs.pymssql

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/miq4qyj4dcwdxpwba5k1gwx32iwq0iyl-python3.6-pymssql-2.1.4
shrinking /nix/store/miq4qyj4dcwdxpwba5k1gwx32iwq0iyl-python3.6-pymssql-2.1.4/lib/python3.6/site-packages/_mssql.cpython-36m-x86_64-linux-gnu.so
shrinking /nix/store/miq4qyj4dcwdxpwba5k1gwx32iwq0iyl-python3.6-pymssql-2.1.4/lib/python3.6/site-packages/pymssql.cpython-36m-x86_64-linux-gnu.so
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/miq4qyj4dcwdxpwba5k1gwx32iwq0iyl-python3.6-pymssql-2.1.4/lib
patching script interpreter paths in /nix/store/miq4qyj4dcwdxpwba5k1gwx32iwq0iyl-python3.6-pymssql-2.1.4
checking for references to /build in /nix/store/miq4qyj4dcwdxpwba5k1gwx32iwq0iyl-python3.6-pymssql-2.1.4...
/nix/store/68qm8zllkckplf6iyjphskc43j2w943h-python2.7-pymssql-2.1.4
/nix/store/miq4qyj4dcwdxpwba5k1gwx32iwq0iyl-python3.6-pymssql-2.1.4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.pymssql, python3.pkgs.pymssql

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ximijw720yrzzawd0b77c7k7l7aihn90-python3.6-pymssql-2.1.4
shrinking /nix/store/ximijw720yrzzawd0b77c7k7l7aihn90-python3.6-pymssql-2.1.4/lib/python3.6/site-packages/_mssql.cpython-36m-aarch64-linux-gnu.so
shrinking /nix/store/ximijw720yrzzawd0b77c7k7l7aihn90-python3.6-pymssql-2.1.4/lib/python3.6/site-packages/pymssql.cpython-36m-aarch64-linux-gnu.so
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ximijw720yrzzawd0b77c7k7l7aihn90-python3.6-pymssql-2.1.4/lib
patching script interpreter paths in /nix/store/ximijw720yrzzawd0b77c7k7l7aihn90-python3.6-pymssql-2.1.4
checking for references to /build in /nix/store/ximijw720yrzzawd0b77c7k7l7aihn90-python3.6-pymssql-2.1.4...
/nix/store/9l1v0vn7b2h0p4alhqhri7wk825r9z2k-python2.7-pymssql-2.1.4
/nix/store/ximijw720yrzzawd0b77c7k7l7aihn90-python3.6-pymssql-2.1.4

FRidh
FRidh requested changes Nov 19, 2018
View reviewed changes
pkgs/development/python-modules/pymssql/default.nix

buildInputs = [cython setuptools-git];
propagatedBuildInputs = [freetds];
doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the tests disabled? Include a comment in the expression explaining why the tests are disabled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests require an SQL Server instance, so I just skipped them.
If that's OK, I'll add the comment right away

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FRidh I added the comment. Let me know if that's all

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python2.pkgs.pymssql, python3.pkgs.pymssql

Partial log (click to expand)

Processing ./pymssql-2.1.4-cp36-cp36m-macosx_10_6_x86_64.whl
Installing collected packages: pymssql
Successfully installed pymssql-2.1.4
/private/tmp/nix-build-python3.6-pymssql-2.1.4.drv-0/pymssql-2.1.4
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/kwjs32dqw5wkcxj1i2j1ibp57xahfmpp-python3.6-pymssql-2.1.4/lib
patching script interpreter paths in /nix/store/kwjs32dqw5wkcxj1i2j1ibp57xahfmpp-python3.6-pymssql-2.1.4
/nix/store/nkyd6avjnlfvyimaw7a5mw7r8j9j1nz3-python2.7-pymssql-2.1.4
/nix/store/kwjs32dqw5wkcxj1i2j1ibp57xahfmpp-python3.6-pymssql-2.1.4

@FRidh
Copy link
Member

FRidh commented Nov 23, 2018

@GrahamcOfBorg build python2.pkgs.pymssql python3.pkgs.pymssql

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python2.pkgs.pymssql, python3.pkgs.pymssql

Partial log (click to expand)

Processing ./pymssql-2.1.4-cp37-cp37m-macosx_10_6_x86_64.whl
Installing collected packages: pymssql
Successfully installed pymssql-2.1.4
/private/tmp/nix-build-python3.7-pymssql-2.1.4.drv-0/pymssql-2.1.4
post-installation fixup
strip is /nix/store/rk3p99jbj4idl3dkkg1rxja5gz0qgs98-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/s429mp3qb281qpjg058c24rfigdmymsw-python3.7-pymssql-2.1.4/lib
patching script interpreter paths in /nix/store/s429mp3qb281qpjg058c24rfigdmymsw-python3.7-pymssql-2.1.4
/nix/store/cjm097p9fw0g3ggqz6w6cmdbbl1fhk05-python2.7-pymssql-2.1.4
/nix/store/s429mp3qb281qpjg058c24rfigdmymsw-python3.7-pymssql-2.1.4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.pymssql, python3.pkgs.pymssql

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/h3id44b8pgwjg431pp35mp3ykfl7z3c7-python3.7-pymssql-2.1.4
shrinking /nix/store/h3id44b8pgwjg431pp35mp3ykfl7z3c7-python3.7-pymssql-2.1.4/lib/python3.7/site-packages/_mssql.cpython-37m-aarch64-linux-gnu.so
shrinking /nix/store/h3id44b8pgwjg431pp35mp3ykfl7z3c7-python3.7-pymssql-2.1.4/lib/python3.7/site-packages/pymssql.cpython-37m-aarch64-linux-gnu.so
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/h3id44b8pgwjg431pp35mp3ykfl7z3c7-python3.7-pymssql-2.1.4/lib
patching script interpreter paths in /nix/store/h3id44b8pgwjg431pp35mp3ykfl7z3c7-python3.7-pymssql-2.1.4
checking for references to /build in /nix/store/h3id44b8pgwjg431pp35mp3ykfl7z3c7-python3.7-pymssql-2.1.4...
/nix/store/ij95pfgv3s746pvl5yfwq6qygwdc8pk4-python2.7-pymssql-2.1.4
/nix/store/h3id44b8pgwjg431pp35mp3ykfl7z3c7-python3.7-pymssql-2.1.4

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.pymssql, python3.pkgs.pymssql

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/lyjfmmv66kyfh46qwqilwnwcc6biw2gz-python3.7-pymssql-2.1.4
shrinking /nix/store/lyjfmmv66kyfh46qwqilwnwcc6biw2gz-python3.7-pymssql-2.1.4/lib/python3.7/site-packages/pymssql.cpython-37m-x86_64-linux-gnu.so
shrinking /nix/store/lyjfmmv66kyfh46qwqilwnwcc6biw2gz-python3.7-pymssql-2.1.4/lib/python3.7/site-packages/_mssql.cpython-37m-x86_64-linux-gnu.so
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lyjfmmv66kyfh46qwqilwnwcc6biw2gz-python3.7-pymssql-2.1.4/lib
patching script interpreter paths in /nix/store/lyjfmmv66kyfh46qwqilwnwcc6biw2gz-python3.7-pymssql-2.1.4
checking for references to /build in /nix/store/lyjfmmv66kyfh46qwqilwnwcc6biw2gz-python3.7-pymssql-2.1.4...
/nix/store/aaxc22j5lk28rb56ih9xzk7v0sfr3ff3-python2.7-pymssql-2.1.4
/nix/store/lyjfmmv66kyfh46qwqilwnwcc6biw2gz-python3.7-pymssql-2.1.4

@FRidh FRidh merged commit 1bf18e4 into NixOS:master Nov 23, 2018
@mredaelli mredaelli deleted the pymssql branch November 23, 2018 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mredaelli @FRidh @GrahamcOfBorg