Add disks option to libvirt backend. Similar to VirtualBox option. #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses nix/generate-ext4-image to generate an appropriately sized ext4 image. Unless a baseImage path is provided as part of the network. This is performed during create by the libvirtd backend python code. libvirtd-image.nix was renamed libvirtd-root-image to clarify the image build performed is only for the root filesystem with the base nix install.
|
In general I think it's a good step forward, but the code is too fragmented. Both of the FS generation images should use |
|
The root file system definitely should use make-disk-image. Any reason the original disk image code did not? I don't see anything obvious. The alternate disks should be images without content. The make-disk-image function installs a nixos configuration onto the generated disk image. Is that appropriate in this case? I'll change the root filesystem disk image generation. Let me know about the alternate disks. Any other aspect need revision? |
|
clearing old PRs. I'm no longer developing on nixops. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses nix/generate-ext4-image to generate an appropriately sized ext4 image.
Unless a baseImage path is provided as part of the network.
This is performed during create by the libvirtd backend python code.
libvirtd-image.nix was renamed libvirtd-root-image to clarify the image build
performed is only for the root filesystem with the base nix install.