Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add traverso: init at 0.49.5 #50747

Merged
merged 1 commit into from Nov 22, 2018
Merged

Add traverso: init at 0.49.5 #50747

merged 1 commit into from Nov 22, 2018

Conversation

coreyoconnor
Copy link
Contributor

@coreyoconnor coreyoconnor commented Nov 19, 2018

Motivation for this change

add traverso and WavePack dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@coreyoconnor
Copy link
Contributor Author

oops: missing meta. adding and will re-update

@coreyoconnor coreyoconnor force-pushed the add-traverso branch 2 times, most recently from 9c08e60 to 4fcddb7 Compare November 19, 2018 17:01
@coreyoconnor
Copy link
Contributor Author

Done. One question tho: Traverso has both GPL and LGPL licenses in the COPYING file. I picked LGPL for the meta. Is this correct?

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: traverso

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/q9i3hcjpdfhjrb3byjpg39jywhivnmzw-traverso-0.49.5
shrinking /nix/store/q9i3hcjpdfhjrb3byjpg39jywhivnmzw-traverso-0.49.5/bin/traverso
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/q9i3hcjpdfhjrb3byjpg39jywhivnmzw-traverso-0.49.5/bin
patching script interpreter paths in /nix/store/q9i3hcjpdfhjrb3byjpg39jywhivnmzw-traverso-0.49.5
checking for references to /build in /nix/store/q9i3hcjpdfhjrb3byjpg39jywhivnmzw-traverso-0.49.5...
postPatchMkspecs
/nix/store/q9i3hcjpdfhjrb3byjpg39jywhivnmzw-traverso-0.49.5

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: traverso

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/zf00l2s680hv03jlnpk1h1jzld7z8hlh-traverso-0.49.5
shrinking /nix/store/zf00l2s680hv03jlnpk1h1jzld7z8hlh-traverso-0.49.5/bin/traverso
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zf00l2s680hv03jlnpk1h1jzld7z8hlh-traverso-0.49.5/bin
patching script interpreter paths in /nix/store/zf00l2s680hv03jlnpk1h1jzld7z8hlh-traverso-0.49.5
checking for references to /build in /nix/store/zf00l2s680hv03jlnpk1h1jzld7z8hlh-traverso-0.49.5...
postPatchMkspecs
/nix/store/zf00l2s680hv03jlnpk1h1jzld7z8hlh-traverso-0.49.5

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: traverso

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


pkgs/development/libraries/WavePack/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/traverso/default.nix Outdated Show resolved Hide resolved
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 19, 2018

The first commit message too should be wavpack: init at 5.1.0

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: traverso

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: traverso

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/91cv2yj4cc120cmz24wylcwcbnjssqgr-traverso-0.49.5
shrinking /nix/store/91cv2yj4cc120cmz24wylcwcbnjssqgr-traverso-0.49.5/bin/traverso
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/91cv2yj4cc120cmz24wylcwcbnjssqgr-traverso-0.49.5/bin
patching script interpreter paths in /nix/store/91cv2yj4cc120cmz24wylcwcbnjssqgr-traverso-0.49.5
checking for references to /build in /nix/store/91cv2yj4cc120cmz24wylcwcbnjssqgr-traverso-0.49.5...
postPatchMkspecs
/nix/store/91cv2yj4cc120cmz24wylcwcbnjssqgr-traverso-0.49.5

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: traverso

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/g1yvfq3m9bi712qqf0cvr1a6jlng6fij-traverso-0.49.5
shrinking /nix/store/g1yvfq3m9bi712qqf0cvr1a6jlng6fij-traverso-0.49.5/bin/traverso
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/g1yvfq3m9bi712qqf0cvr1a6jlng6fij-traverso-0.49.5/bin
patching script interpreter paths in /nix/store/g1yvfq3m9bi712qqf0cvr1a6jlng6fij-traverso-0.49.5
checking for references to /build in /nix/store/g1yvfq3m9bi712qqf0cvr1a6jlng6fij-traverso-0.49.5...
postPatchMkspecs
/nix/store/g1yvfq3m9bi712qqf0cvr1a6jlng6fij-traverso-0.49.5

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/traverso/default.nix Outdated Show resolved Hide resolved
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 20, 2018

Oh so wavpack was already in nixpkgs. I didn't check that the first time.

I left more comments on traverso derivation
(and sorry for not asking changes in one batch)

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: traverso

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: traverso

Partial log (click to expand)

-- Using unsigned short
-- Check if the system is big endian - little endian
CMake Error at CMakeLists.txt:134 (MESSAGE):
  Program pkg-config not found


-- Configuring incomplete, errors occurred!
See also "/build/traverso-0.49.5/build/CMakeFiles/CMakeOutput.log".
builder for '/nix/store/nlprwvliq9wnlcmbbn74ap57l4g067hj-traverso-0.49.5.drv' failed with exit code 1
error: build of '/nix/store/nlprwvliq9wnlcmbbn74ap57l4g067hj-traverso-0.49.5.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: traverso

Partial log (click to expand)

-- Using unsigned short
-- Check if the system is big endian - little endian
CMake Error at CMakeLists.txt:134 (MESSAGE):
  Program pkg-config not found


-- Configuring incomplete, errors occurred!
See also "/build/traverso-0.49.5/build/CMakeFiles/CMakeOutput.log".
builder for '/nix/store/3160j5dka779sn4xl43gjhzj2jdxp8yc-traverso-0.49.5.drv' failed with exit code 1
error: build of '/nix/store/3160j5dka779sn4xl43gjhzj2jdxp8yc-traverso-0.49.5.drv' failed

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 21, 2018

You need to add pkgconfig to your nativeBuildInputs now it seems

@coreyoconnor
Copy link
Contributor Author

Wow. There are a number of differences in 0.49.5 from the git repo I was working off of. Definitely a mess.

Unrelated to traverso, I'm unable to build master right now. Tho I was able to build from a fork of nixpkgs. Testing via borg for compilation. :\

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: traverso

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: traverso

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hixji58mabx0mhmscxyd9wrvkw2qmchq-traverso-0.49.5
shrinking /nix/store/hixji58mabx0mhmscxyd9wrvkw2qmchq-traverso-0.49.5/bin/traverso
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hixji58mabx0mhmscxyd9wrvkw2qmchq-traverso-0.49.5/bin
patching script interpreter paths in /nix/store/hixji58mabx0mhmscxyd9wrvkw2qmchq-traverso-0.49.5
checking for references to /build in /nix/store/hixji58mabx0mhmscxyd9wrvkw2qmchq-traverso-0.49.5...
postPatchMkspecs
/nix/store/hixji58mabx0mhmscxyd9wrvkw2qmchq-traverso-0.49.5

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: traverso

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2kifsla01ryp5wa8dms59l37jsnnl24c-traverso-0.49.5
shrinking /nix/store/2kifsla01ryp5wa8dms59l37jsnnl24c-traverso-0.49.5/bin/traverso
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2kifsla01ryp5wa8dms59l37jsnnl24c-traverso-0.49.5/bin
patching script interpreter paths in /nix/store/2kifsla01ryp5wa8dms59l37jsnnl24c-traverso-0.49.5
checking for references to /build in /nix/store/2kifsla01ryp5wa8dms59l37jsnnl24c-traverso-0.49.5...
postPatchMkspecs
/nix/store/2kifsla01ryp5wa8dms59l37jsnnl24c-traverso-0.49.5

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 22, 2018

Thanks a lot for the contribution.

@c0bw3b c0bw3b merged commit 9613310 into NixOS:master Nov 22, 2018
@rsijrier
Copy link

Wow. There are a number of differences in 0.49.5 from the git repo I was working off of. Definitely a mess.

Currently cleaning up Traverso sources and working on git repo right now. If you need any help with stable or development version, contact me at http://traverso-daw.org

Regards, Remon

@coreyoconnor coreyoconnor deleted the add-traverso branch April 12, 2019 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants