Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eigen: replace with eigen3_3: 3.2.10 -> 3.3.5 #50702

Merged
merged 1 commit into from Nov 19, 2018
Merged

eigen: replace with eigen3_3: 3.2.10 -> 3.3.5 #50702

merged 1 commit into from Nov 19, 2018

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Nov 19, 2018

Motivation for this change

Remove outdated eigen 3.2.

(Prerequisite: 023e544.)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@orivej
Copy link
Contributor Author

orivej commented Nov 19, 2018

Do you need to keep eigen3_3 defined for convenience of packages outside Nixpkgs?

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: eigen

Partial log (click to expand)

/nix/store/bqlfvh78c1l835fglka6l9m9d8cs3j08-eigen-3.3.5

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: eigen

Partial log (click to expand)

-- Installing: /nix/store/506bv3sjc8khgyslcf80bkszan4pf54r-eigen-3.3.5/include/eigen3/unsupported/Eigen/CXX11/src/Tensor/TensorBroadcasting.h
-- Installing: /nix/store/506bv3sjc8khgyslcf80bkszan4pf54r-eigen-3.3.5/include/eigen3/unsupported/Eigen/CXX11/src/Tensor/TensorBase.h
-- Installing: /nix/store/506bv3sjc8khgyslcf80bkszan4pf54r-eigen-3.3.5/include/eigen3/unsupported/Eigen/CXX11/src/Tensor/TensorAssign.h
-- Installing: /nix/store/506bv3sjc8khgyslcf80bkszan4pf54r-eigen-3.3.5/include/eigen3/unsupported/Eigen/CXX11/src/Tensor/TensorArgMax.h
-- Installing: /nix/store/506bv3sjc8khgyslcf80bkszan4pf54r-eigen-3.3.5/include/eigen3/unsupported/Eigen/CXX11/src/Tensor/Tensor.h
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/506bv3sjc8khgyslcf80bkszan4pf54r-eigen-3.3.5
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/506bv3sjc8khgyslcf80bkszan4pf54r-eigen-3.3.5
checking for references to /build in /nix/store/506bv3sjc8khgyslcf80bkszan4pf54r-eigen-3.3.5...

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: eigen

Partial log (click to expand)

these paths will be fetched (0.75 MiB download, 6.54 MiB unpacked):
  /nix/store/iv6sglpzciv7sv4lvy3jcvf1y25lniga-eigen-3.3.5
copying path '/nix/store/iv6sglpzciv7sv4lvy3jcvf1y25lniga-eigen-3.3.5' from 'https://cache.nixos.org'...
/nix/store/iv6sglpzciv7sv4lvy3jcvf1y25lniga-eigen-3.3.5

@orivej orivej changed the base branch from master to staging November 19, 2018 10:28
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: eigen

Partial log (click to expand)

-- Installing: /nix/store/i1kjig5qdrpkb6hm2533g6xj3rg8v8kw-eigen-3.3.5/include/eigen3/unsupported/Eigen/CXX11/src/ThreadPool/RunQueue.h
-- Installing: /nix/store/i1kjig5qdrpkb6hm2533g6xj3rg8v8kw-eigen-3.3.5/include/eigen3/unsupported/Eigen/CXX11/src/ThreadPool/ThreadYield.h
-- Installing: /nix/store/i1kjig5qdrpkb6hm2533g6xj3rg8v8kw-eigen-3.3.5/include/eigen3/unsupported/Eigen/CXX11/src/ThreadPool/ThreadPoolInterface.h
-- Installing: /nix/store/i1kjig5qdrpkb6hm2533g6xj3rg8v8kw-eigen-3.3.5/include/eigen3/unsupported/Eigen/CXX11/src/ThreadPool/NonBlockingThreadPool.h
-- Installing: /nix/store/i1kjig5qdrpkb6hm2533g6xj3rg8v8kw-eigen-3.3.5/include/eigen3/unsupported/Eigen/CXX11/src/ThreadPool/ThreadLocal.h
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/i1kjig5qdrpkb6hm2533g6xj3rg8v8kw-eigen-3.3.5
strip is /nix/store/j13c9z0z495wxdc97if8z451x53m1j25-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/i1kjig5qdrpkb6hm2533g6xj3rg8v8kw-eigen-3.3.5
checking for references to /build/ in /nix/store/i1kjig5qdrpkb6hm2533g6xj3rg8v8kw-eigen-3.3.5...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: eigen

Partial log (click to expand)

-- Installing: /nix/store/mx8v8ilx8rw4xiq6vjd48glndzxk325i-eigen-3.3.5/include/eigen3/unsupported/Eigen/CXX11/src/Tensor/TensorBroadcasting.h
-- Installing: /nix/store/mx8v8ilx8rw4xiq6vjd48glndzxk325i-eigen-3.3.5/include/eigen3/unsupported/Eigen/CXX11/src/Tensor/TensorBase.h
-- Installing: /nix/store/mx8v8ilx8rw4xiq6vjd48glndzxk325i-eigen-3.3.5/include/eigen3/unsupported/Eigen/CXX11/src/Tensor/TensorAssign.h
-- Installing: /nix/store/mx8v8ilx8rw4xiq6vjd48glndzxk325i-eigen-3.3.5/include/eigen3/unsupported/Eigen/CXX11/src/Tensor/TensorArgMax.h
-- Installing: /nix/store/mx8v8ilx8rw4xiq6vjd48glndzxk325i-eigen-3.3.5/include/eigen3/unsupported/Eigen/CXX11/src/Tensor/Tensor.h
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/mx8v8ilx8rw4xiq6vjd48glndzxk325i-eigen-3.3.5
strip is /nix/store/1jprj383qnzd50vn8qq3a0id6a08a9fi-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/mx8v8ilx8rw4xiq6vjd48glndzxk325i-eigen-3.3.5
checking for references to /build/ in /nix/store/mx8v8ilx8rw4xiq6vjd48glndzxk325i-eigen-3.3.5...

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: eigen

Partial log (click to expand)

cannot build derivation '/nix/store/nzs3hh592vcf22pn66lzxi8kkkvnh6b7-xnu-osx-10.11.6.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/7i9r5m9b470njypa097f6hkgp7ann67b-IOKit-osx-10.11.6.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/q3c2569rlxzf35b4hyfhc2a9qw8hrsc1-curl-7.62.0.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/kd0dgkzl8apiyxgsg591p01wlxys2r4y-configd-osx-10.8.5.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/33sd35pk35alb1r654g8vmvqg137s8yv-python-2.7.15.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/qn3l6rl1m43sgs4s017sasrvaasdcwag-libxml2-2.9.8.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/s99cpjsminil1srvnjlyv8593m697nkk-libarchive-3.3.3.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/yv7mn0kshpzjqpdccy502fm107q22s3z-cmake-3.12.1.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/lr6ssc1dsvf8s7r4zv266nj6dhqasirg-eigen-3.3.5.drv': 2 dependencies couldn't be built
error: build of '/nix/store/lr6ssc1dsvf8s7r4zv266nj6dhqasirg-eigen-3.3.5.drv' failed

@7c6f434c
Copy link
Member

Seems fine indeed…

@7c6f434c 7c6f434c merged commit 0c0a243 into NixOS:staging Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@svanderburg svanderburg Awaiting requested review from svanderburg

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orivej @GrahamcOfBorg @7c6f434c