Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ntp default restrictions #50762

Merged
merged 4 commits into from
Nov 28, 2018
Merged

Ntp default restrictions #50762

merged 4 commits into from
Nov 28, 2018
+46 −2

Conversation

reardencode
Copy link
Contributor

Motivation for this change

#50732

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@reardencode reardencode force-pushed the ntp-default-restrictions branch from f4de05f to 96a10be Compare November 19, 2018 18:01
@reardencode
Copy link
Contributor Author

sorry about that initial push - failed to push rebase onto master.

@Mic92
Copy link
Member

Mic92 commented Nov 19, 2018

In https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-1903.xml we should mention the new defaults. Some people maybe rely on them.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 19, 2018
@reardencode
Improve documentation, add release notes

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
1f892b4
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 8.has: changelog 8.has: documentation This PR adds or changes documentation labels Nov 19, 2018
infinisil
infinisil requested changes Nov 21, 2018
View reviewed changes
@Mic92 Mic92 merged commit dacbd5a into NixOS:master Nov 28, 2018
@reardencode reardencode deleted the ntp-default-restrictions branch November 28, 2018 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92

@infinisil infinisil

@coretemp coretemp

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@reardencode @Mic92 @infinisil @coretemp @GrahamcOfBorg