Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages.phantomjs: remove override #50744

Merged
merged 1 commit into from Nov 19, 2018
Merged

nodePackages.phantomjs: remove override #50744

merged 1 commit into from Nov 19, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 19, 2018

a left-over from #50451

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Nov 19, 2018

cc @gebner

@Mic92 Mic92 merged commit a69a857 into NixOS:master Nov 19, 2018
@gebner
Copy link
Member

gebner commented Nov 19, 2018

Thanks!

@Mic92 Mic92 deleted the phantomjs branch November 19, 2018 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @gebner @GrahamcOfBorg