Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildGoPackage: remove build-time dependency on parallel (and perl) #50752

Closed
wants to merge 1 commit into from
Closed

buildGoPackage: remove build-time dependency on parallel (and perl) #50752

wants to merge 1 commit into from

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 19, 2018 •
edited

xargs is as good as parallel for our job

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Nov 19, 2018

Currently running nix-review. I already tested some non-trivial packages.

@adisbladis
Copy link
Member

While I haven't tested this myself I see no reason not to merge it provided your testing is OK @Mic92.

@Mic92
Copy link
Member Author

Mic92 commented Nov 20, 2018

@GrahamcOfBorg build direnv

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: direnv

Partial log (click to expand)

strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/77kbz4ij3y1ybxvn2cjbsx9d7ifyh043-direnv-2.17.0-bin/bin
patching script interpreter paths in /nix/store/77kbz4ij3y1ybxvn2cjbsx9d7ifyh043-direnv-2.17.0-bin
checking for references to /build in /nix/store/77kbz4ij3y1ybxvn2cjbsx9d7ifyh043-direnv-2.17.0-bin...
cannot find section .dynamic
shrinking RPATHs of ELF executables and libraries in /nix/store/vx7jgqvqjilawnpqaqvs2gg6zdq9fl21-direnv-2.17.0
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/vx7jgqvqjilawnpqaqvs2gg6zdq9fl21-direnv-2.17.0
checking for references to /build in /nix/store/vx7jgqvqjilawnpqaqvs2gg6zdq9fl21-direnv-2.17.0...
/nix/store/77kbz4ij3y1ybxvn2cjbsx9d7ifyh043-direnv-2.17.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: direnv

Partial log (click to expand)

install direnv /nix/store/685dh7pksrqb6fxpysnlskgf6b5hild3-direnv-2.17.0-bin/bin
cp -R man/*.1 /nix/store/685dh7pksrqb6fxpysnlskgf6b5hild3-direnv-2.17.0-bin/share/man/man1
post-installation fixup
gzipping man pages under /nix/store/685dh7pksrqb6fxpysnlskgf6b5hild3-direnv-2.17.0-bin/share/man/
strip is /nix/store/rk3p99jbj4idl3dkkg1rxja5gz0qgs98-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/685dh7pksrqb6fxpysnlskgf6b5hild3-direnv-2.17.0-bin/bin
patching script interpreter paths in /nix/store/685dh7pksrqb6fxpysnlskgf6b5hild3-direnv-2.17.0-bin
strip is /nix/store/rk3p99jbj4idl3dkkg1rxja5gz0qgs98-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/55pvr46qy441hql6qzyjm32wj8jjzj0v-direnv-2.17.0
/nix/store/685dh7pksrqb6fxpysnlskgf6b5hild3-direnv-2.17.0-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: direnv

Partial log (click to expand)

strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dd9a6jvjw24hrbhv0q24qglpj713wv40-direnv-2.17.0-bin/bin
patching script interpreter paths in /nix/store/dd9a6jvjw24hrbhv0q24qglpj713wv40-direnv-2.17.0-bin
checking for references to /build in /nix/store/dd9a6jvjw24hrbhv0q24qglpj713wv40-direnv-2.17.0-bin...
cannot find section .dynamic
shrinking RPATHs of ELF executables and libraries in /nix/store/xkjcz10z6mgj75sjwr97nh6a0b3dzlvm-direnv-2.17.0
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/xkjcz10z6mgj75sjwr97nh6a0b3dzlvm-direnv-2.17.0
checking for references to /build in /nix/store/xkjcz10z6mgj75sjwr97nh6a0b3dzlvm-direnv-2.17.0...
/nix/store/dd9a6jvjw24hrbhv0q24qglpj713wv40-direnv-2.17.0-bin

@FRidh FRidh closed this in 9564927 Dec 8, 2018
@Mic92 Mic92 deleted the build-go-package branch December 8, 2018 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis adisbladis approved these changes

Assignees
No one assigned
Labels
6.topic: golang 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @adisbladis @GrahamcOfBorg