Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slic3r-prusa3d: multiple fixes #50720

Merged
merged 3 commits into from Nov 28, 2018
Merged

slic3r-prusa3d: multiple fixes #50720

merged 3 commits into from Nov 28, 2018

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented Nov 19, 2018 •
edited

Motivation for this change
  1. Fix sha256 for version 1.41.1 because the release tag was updated a few days after the initial release.
  2. building of the package broke with the update to nlopt 2.5.0. After patching the lib name in the source it works just fine.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc

@Moredread
nlopt: move version into the derivation itself
6aebaa0
@Moredread
slic3r-prusa3d: fix sha256 for version 1.41.1
d9a02b8 
The release tag was updated a few days after the initial release.
@Moredread
slic3r-prusa3d: patch lib name for newer nlopt versions
59ba6a3 
The upgrade to version 2.5.0 of nlopt broke building of slic3r-prusa3d
because the C++ version of the nlopt lib is now integrated into
`libnlopt`.
@Moredread Moredread changed the title Slic3r prusa3d/1.41.1 fixes slic3r-prusa3d: multiple fixes Nov 19, 2018
@Moredread
Copy link
Contributor Author

cc @thorstenweber83

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 28, 2018

@GrahamcOfBorg build nlopt slic3r-prusa3d

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nlopt

The following builds were skipped because they don't evaluate on aarch64-linux: slic3r-prusa3d

Partial log (click to expand)

-- Installing: /nix/store/8qb77pvjd65ma7cjxpqcmrfp14ghc6gi-nlopt-2.5.0/share/man/man3/nlopt_minimize_constrained.3
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/8qb77pvjd65ma7cjxpqcmrfp14ghc6gi-nlopt-2.5.0
shrinking /nix/store/8qb77pvjd65ma7cjxpqcmrfp14ghc6gi-nlopt-2.5.0/lib/libnlopt.so.0.9.0
gzipping man pages under /nix/store/8qb77pvjd65ma7cjxpqcmrfp14ghc6gi-nlopt-2.5.0/share/man/
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8qb77pvjd65ma7cjxpqcmrfp14ghc6gi-nlopt-2.5.0/lib
patching script interpreter paths in /nix/store/8qb77pvjd65ma7cjxpqcmrfp14ghc6gi-nlopt-2.5.0
checking for references to /build in /nix/store/8qb77pvjd65ma7cjxpqcmrfp14ghc6gi-nlopt-2.5.0...
/nix/store/8qb77pvjd65ma7cjxpqcmrfp14ghc6gi-nlopt-2.5.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nlopt, slic3r-prusa3d

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/crk9dz6nvl4bvflpax9nfy5k6rha9idi-slic3r-prusa-edition-1.41.1
shrinking /nix/store/crk9dz6nvl4bvflpax9nfy5k6rha9idi-slic3r-prusa-edition-1.41.1/lib/slic3r-prusa3d/auto/Slic3r/XS/XS.so
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/crk9dz6nvl4bvflpax9nfy5k6rha9idi-slic3r-prusa-edition-1.41.1/lib  /nix/store/crk9dz6nvl4bvflpax9nfy5k6rha9idi-slic3r-prusa-edition-1.41.1/bin
patching script interpreter paths in /nix/store/crk9dz6nvl4bvflpax9nfy5k6rha9idi-slic3r-prusa-edition-1.41.1
/nix/store/crk9dz6nvl4bvflpax9nfy5k6rha9idi-slic3r-prusa-edition-1.41.1/bin/.slic3r-prusa3d-wrapped: interpreter directive changed from "/usr/bin/env perl" to "/nix/store/svqh993szsgi152vywx5ybyh1k22l5j1-perl-5.28.0/bin/perl"
checking for references to /build in /nix/store/crk9dz6nvl4bvflpax9nfy5k6rha9idi-slic3r-prusa-edition-1.41.1...
/nix/store/cvwwj8vlnjcvr90d0l6lpilk0j1fymrd-nlopt-2.5.0
/nix/store/crk9dz6nvl4bvflpax9nfy5k6rha9idi-slic3r-prusa-edition-1.41.1

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: nlopt, slic3r-prusa3d

Partial log (click to expand)

cannot build derivation '/nix/store/vf1kw6lnx92svvzkysz1cphx8vikp272-perl5.28.0-Alien-wxWidgets-0.69.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/zsq8j810kjz5gl6r0zf2h8ksimlrh55v-xorg-server-1.18.4.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/51j6bqijjcz3p2w1lq9isb2772cv173j-perl5.28.0-Wx-0.9932.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/7ak99kfzg4nx0m6y6c6lvp3zs8qa0n6j-xf86-video-dummy-0.3.8.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/gkljhn3p1cm7pmj22arx1gphaql017jr-dummy-xorg.conf.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/wrrrjp4jdzs2hvnj28m4ynd54kfahydb-xdummy.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/cyq1sjfnn6v9pydy7y32m1x8y30fwsk2-perl5.28.0-OpenGL-0.70.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/kik90hxf955bqchxly2kxvp296w3jmzd-perl5.28.0-Wx-GLCanvas-0.09.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/sjscz7qf24i5n0hxrmg2lkj6xx4frcdw-slic3r-prusa-edition-1.41.1.drv': 6 dependencies couldn't be built
error: build of '/nix/store/sjscz7qf24i5n0hxrmg2lkj6xx4frcdw-slic3r-prusa-edition-1.41.1.drv' failed

@c0bw3b c0bw3b merged commit b5784b4 into NixOS:master Nov 28, 2018
@Moredread Moredread deleted the slic3r-prusa3d/1.41.1-fixes branch December 1, 2018 00:13
matejc pushed a commit to matejc/nixpkgs that referenced this pull request Dec 2, 2018
@c0bw3b @matejc
Merge pull request NixOS#50720 from Moredread/slic3r-prusa3d/1.41.1-f…
bd168c2 
…ixes

slic3r-prusa3d: multiple fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Moredread @c0bw3b @GrahamcOfBorg