Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghc: Adding sphinx as build dependency to build man pages #50920

Closed
wants to merge 1 commit into from
Closed

ghc: Adding sphinx as build dependency to build man pages #50920

wants to merge 1 commit into from
+11 −7

Conversation

cyounkins
Copy link
Contributor

Motivation for this change

I built 8.4.4 but not the other versions as it takes quite awhile to compile.

Fixes #49627 Hopefully it will stay fixed this time.

Would appreciate a review from @peti

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

peti
peti requested changes Nov 22, 2018
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please target the branch haskell-updates for this PR instead of master.

peti pushed a commit that referenced this pull request Nov 22, 2018
@cyounkins @peti
ghc: Adding sphinx as build dependency to build man pages
4e41494 
Fixes #49627.
Closes #50920.
@peti
Copy link
Member

peti commented Nov 22, 2018

I cherry-picked the commit as 4e41494. Test builds are running at https://hydra.nixos.org/jobset/nixpkgs/haskell-updates. I'll merge to master ASAP when the test builds succeed.

peti pushed a commit that referenced this pull request Nov 24, 2018
@cyounkins @peti
ghc: Adding sphinx as build dependency to build man pages

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
6dd3e2f 
Fixes #49627.
Closes #50920.
@peti peti closed this in a655fb9 Nov 25, 2018
@dtzWill
Copy link
Member

dtzWill commented Nov 25, 2018

Breaks build for me? But haven't investigated beyond local tree. Quick look at hydra suggests it's not a general problem but just mentioning in case anyone else encounters this.

In case this helps or anyone's curious:

making output directory...
building [mo]: targets for 0 po files that are out of date
building [html]: targets for 4 source files that are out of date
updating environment: 4 added, 0 changed, 0 removed
reading sources... [ 25%] index
reading sources... [ 50%] intro
reading sources... [ 75%] invoking
reading sources... [100%] markup

looking for now-outdated files... none found
pickling environment... done
checking consistency... done
preparing documents... done
writing output... [ 25%] index

Extension error:
The 'ghc-flag' directive is already registered to domain std

Extension error:
The 'ghc-flag' directive is already registered to domain std
writing output... [ 50%] intro
writing output... [ 75%] invoking
make[1]: *** [docs/users_guide/ghc.mk:16: docs/users_guide/build-html/users_guide/index.html] Error 2
make[1]: *** Waiting for unfinished jobs....
make[1]: *** [docs/users_guide/ghc.mk:28: docs/users_guide/build-man/ghc.1] Error 2
writing output... [100%] markup

/build/ghc-8.4.4/utils/haddock/doc/invoking.rst:457: WARNING: unknown option: -cpp
generating indices... genindex
writing additional pages... search
copying static files... done
copying extra files... done
dumping search index in English (code: en) ... done
dumping object inventory... done
build succeeded, 1 warning.

The HTML pages are in .build-html.
cp -R utils/haddock/doc/.build-html utils/haddock/doc/haddock
make: *** [Makefile:127: all] Error 2
builder for '/nix/store/h07kn8nz18jjkbdjv9vj7pyxp2n7zrbm-ghc-8.4.4.drv' failed with exit code 2

Don't know if it matters but using sphinx 1.8.1/1.8.2, as opposed to the 1.7.9 on master-- but no reason to believe that's related :).

@cyounkins cyounkins deleted the ghc_sphinx branch November 26, 2018 17:47
@jacereda jacereda mentioned this pull request Feb 17, 2019
Merged
10 tasks
@kquick
Copy link
Contributor

kquick commented Feb 18, 2019

Also breaking the GHC 8.4.4 build here, although 8.2.2 and 8.6.3 are building fine.

@kquick
Copy link
Contributor

kquick commented Feb 18, 2019

For others tracking this down: 102c624 fixes #55662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti

@basvandijk basvandijk

@ryantm ryantm

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GHC is missing a manpage
5 participants
@cyounkins @peti @dtzWill @kquick @GrahamcOfBorg