Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sky: init at 2.1.7369 #50911

Merged
merged 6 commits into from Apr 21, 2019
Merged

sky: init at 2.1.7369 #50911

merged 6 commits into from Apr 21, 2019

Conversation

Scriptkiddi
Copy link
Contributor

Motivation for this change

To use a NixOs at work I need to use skype buisness

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Scriptkiddi Scriptkiddi changed the title sky: init at 2.1.7300.1 sky: init at 2.1.7295.1 Dec 13, 2018
@Scriptkiddi
Copy link
Contributor Author

@c0bw3b is there something else that I missed, thanks for reviewing so far :D

@Scriptkiddi
Copy link
Contributor Author

@c0bw3b Merry Christmas

@Scriptkiddi
Copy link
Contributor Author

any updates c0bw3b

@Scriptkiddi
Copy link
Contributor Author

@alyssais can you take a look

@c0bw3b
Copy link
Contributor

c0bw3b commented Apr 20, 2019

Hello,
Sorry to leave you hanging there.

I just tried to "build" it but it seems the source deb for 2.1.7295 isn't available anymore.
Could you please refresh your PR to fetch the most recent upstream version? (2.1.7369)

@Scriptkiddi Scriptkiddi changed the title sky: init at 2.1.7295.1 sky: init at 2.1.7369 Apr 21, 2019
@Scriptkiddi
Copy link
Contributor Author

@c0bw3b done

@Scriptkiddi
Copy link
Contributor Author

@c0bw3b done

@c0bw3b c0bw3b merged commit 66a1dab into NixOS:master Apr 21, 2019
@knedlsepp
Copy link
Member

This doesn't run on my machine:

./result/bin/sky: error while loading shared libraries: libavcodec-ffmpeg.so.56: cannot open shared object file: No such file or directory

I did package this thing some time ago using autoPatchelfHook. Here's some WIP of updating this to the newest version:
ff529a2

c0bw3b pushed a commit to c0bw3b/nixpkgs that referenced this pull request Apr 22, 2019
@c0bw3b
sky: init at 2.1.7369 (NixOS#50911)
20d2d25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais alyssais left review comments

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Scriptkiddi @c0bw3b @knedlsepp @alyssais @GrahamcOfBorg