Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skaffold: 0.16.0 -> 0.18.0 #50922

Merged
merged 1 commit into from Nov 23, 2018
Merged

skaffold: 0.16.0 -> 0.18.0 #50922

merged 1 commit into from Nov 23, 2018

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Nov 22, 2018 •
edited

Signed-off-by: Vincent Demeester vincent@sbr.pm

Motivation for this change

Bump skaffold to the most recent version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@timokau
Copy link
Member

timokau commented Nov 22, 2018

@GrahamcOfBorg build skaffold

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: skaffold

Partial log (click to expand)

github.com/GoogleContainerTools/skaffold/cmd/skaffold
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/l2w91d8yj50jvgzqzyf1p8fpfgjzbcx0-skaffold-0.18.0-bin
shrinking /nix/store/l2w91d8yj50jvgzqzyf1p8fpfgjzbcx0-skaffold-0.18.0-bin/bin/skaffold
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/l2w91d8yj50jvgzqzyf1p8fpfgjzbcx0-skaffold-0.18.0-bin/bin
patching script interpreter paths in /nix/store/l2w91d8yj50jvgzqzyf1p8fpfgjzbcx0-skaffold-0.18.0-bin
checking for references to /build in /nix/store/l2w91d8yj50jvgzqzyf1p8fpfgjzbcx0-skaffold-0.18.0-bin...
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: skaffold

Partial log (click to expand)

find: '/nix/store/r4aw40vdw1k5riz9n18dy8gksypm772x-skaffold-0.18.0': No such file or directory
find: '/nix/store/r4aw40vdw1k5riz9n18dy8gksypm772x-skaffold-0.18.0': No such file or directory
find: '/nix/store/r4aw40vdw1k5riz9n18dy8gksypm772x-skaffold-0.18.0': No such file or directory
find: '/nix/store/r4aw40vdw1k5riz9n18dy8gksypm772x-skaffold-0.18.0': No such file or directory
find: '/nix/store/r4aw40vdw1k5riz9n18dy8gksypm772x-skaffold-0.18.0': No such file or directory
find: '/nix/store/r4aw40vdw1k5riz9n18dy8gksypm772x-skaffold-0.18.0': No such file or directory
find: '/nix/store/r4aw40vdw1k5riz9n18dy8gksypm772x-skaffold-0.18.0': No such file or directory
find: '/nix/store/r4aw40vdw1k5riz9n18dy8gksypm772x-skaffold-0.18.0': No such file or directory
find: '/nix/store/r4aw40vdw1k5riz9n18dy8gksypm772x-skaffold-0.18.0': No such file or directory
find: '/nix/store/r4aw40vdw1k5riz9n18dy8gksypm772x-skaffold-0.18.0': No such file or directory

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: skaffold

Partial log (click to expand)

github.com/GoogleContainerTools/skaffold/cmd/skaffold
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2b7fa7ainkl35sp8n8gwhcv6x657rf9i-skaffold-0.18.0-bin
shrinking /nix/store/2b7fa7ainkl35sp8n8gwhcv6x657rf9i-skaffold-0.18.0-bin/bin/skaffold
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2b7fa7ainkl35sp8n8gwhcv6x657rf9i-skaffold-0.18.0-bin/bin
patching script interpreter paths in /nix/store/2b7fa7ainkl35sp8n8gwhcv6x657rf9i-skaffold-0.18.0-bin
checking for references to /build in /nix/store/2b7fa7ainkl35sp8n8gwhcv6x657rf9i-skaffold-0.18.0-bin...
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip

timokau
timokau reviewed Nov 22, 2018
View reviewed changes
pkgs/development/tools/skaffold/default.nix
# rev is the 0.16.0 commit, mainly for skaffold version command output
rev = "78e443973ee7475ee66d227431596351cf5e2caf";
rev = "34651689be78b2c6bcfbace5072b00b93661f895";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably the comment is outdated? Why is the commit hash used instead of a version tag?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the comment should say 0.18.0 indeed… The main reason it is there is to put the hash in the skaffold version (https://github.com/NixOS/nixpkgs/pull/50922/files#diff-dc620cbbae6ca2d4b7cc22b6447bf85eR15)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see. A nicer way to do this may be to use git rev-parse HEAD to get the current commit hash. For that you'd need to switch from fetchFromGitHub to fetchgit with the leaveDotGit option though to leave the git meta info intact.

If you don't want to do that, I'm fine with merging as-is. Let me know.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timokau Ah, wasn't sure how simple to make it work with buildGoPackage. I feel like we can merge this one as is and think to enhance it as a follow-up 👼

@aanderse
Copy link
Member

Changelog: https://github.com/GoogleContainerTools/skaffold/blob/master/CHANGELOG.md

@vdemeester
skaffold: 0.16.0 -> 0.18.0
5ce7778 
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@timokau timokau merged commit 80c2d42 into NixOS:master Nov 23, 2018
@vdemeester vdemeester deleted the update-skaffold branch November 23, 2018 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vdemeester @timokau @GrahamcOfBorg @aanderse