Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes-helm: tell Helm what version it is #50918

Merged
merged 1 commit into from Nov 22, 2018
Merged

kubernetes-helm: tell Helm what version it is #50918

merged 1 commit into from Nov 22, 2018

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Nov 22, 2018

Motivation for this change

Helm uses its version to determine what version of Tiller (the server
component) to install. Without this patch it thinks it is v2.11+unreleased and
tries to download gcr.io/kubernetes-helm/tiller:v2.11. After the patch it
correctly downloads gcr.io/kubernetes-helm/tiller:v2.11.0. Fixes #49120.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@nightkr
kubernetes-helm: tell Helm what version it is
77cbf0d 
Helm uses its version to determine what version of Tiller (the server
component) to install. Without this patch it thinks it is `v2.11+unreleased` and
tries to download `gcr.io/kubernetes-helm/tiller:v2.11`. After the patch it
correctly downloads `gcr.io/kubernetes-helm/tiller:v2.11.0`. Fixes NixOS#49120.
@FRidh
Copy link
Member

FRidh commented Nov 22, 2018

cc @edude03

@nlewo
Copy link
Member

nlewo commented Nov 22, 2018

cf #50299

@nlewo
Copy link
Member

nlewo commented Nov 22, 2018

@GrahamcOfBorg build helm-kubernetes

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: helm-kubernetes

Partial log (click to expand)

Cannot nix-instantiate `helm-kubernetes' because:
error: attribute 'helm-kubernetes' in selection path 'helm-kubernetes' not found

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: helm-kubernetes

Partial log (click to expand)

Cannot nix-instantiate `helm-kubernetes' because:
error: attribute 'helm-kubernetes' in selection path 'helm-kubernetes' not found

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: helm-kubernetes

Partial log (click to expand)

Cannot nix-instantiate `helm-kubernetes' because:
error: attribute 'helm-kubernetes' in selection path 'helm-kubernetes' not found

@nlewo
Copy link
Member

nlewo commented Nov 22, 2018

oarf:/
@GrahamcOfBorg build kubernetes-helm

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: kubernetes-helm

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/2r0mkwcy2lpp88sq5a09m471h8h9lhcq-helm-2.11.0-bin
shrinking /nix/store/2r0mkwcy2lpp88sq5a09m471h8h9lhcq-helm-2.11.0-bin/bin/rudder
shrinking /nix/store/2r0mkwcy2lpp88sq5a09m471h8h9lhcq-helm-2.11.0-bin/bin/tiller
shrinking /nix/store/2r0mkwcy2lpp88sq5a09m471h8h9lhcq-helm-2.11.0-bin/bin/helm
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2r0mkwcy2lpp88sq5a09m471h8h9lhcq-helm-2.11.0-bin/bin
patching script interpreter paths in /nix/store/2r0mkwcy2lpp88sq5a09m471h8h9lhcq-helm-2.11.0-bin
checking for references to /build in /nix/store/2r0mkwcy2lpp88sq5a09m471h8h9lhcq-helm-2.11.0-bin...
/nix/store/2r0mkwcy2lpp88sq5a09m471h8h9lhcq-helm-2.11.0-bin
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: kubernetes-helm

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/z7km0h85sj0cmqda0hf8g3y4qabs8j9j-helm-2.11.0-bin
shrinking /nix/store/z7km0h85sj0cmqda0hf8g3y4qabs8j9j-helm-2.11.0-bin/bin/rudder
shrinking /nix/store/z7km0h85sj0cmqda0hf8g3y4qabs8j9j-helm-2.11.0-bin/bin/helm
shrinking /nix/store/z7km0h85sj0cmqda0hf8g3y4qabs8j9j-helm-2.11.0-bin/bin/tiller
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/z7km0h85sj0cmqda0hf8g3y4qabs8j9j-helm-2.11.0-bin/bin
patching script interpreter paths in /nix/store/z7km0h85sj0cmqda0hf8g3y4qabs8j9j-helm-2.11.0-bin
checking for references to /build in /nix/store/z7km0h85sj0cmqda0hf8g3y4qabs8j9j-helm-2.11.0-bin...
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
/nix/store/z7km0h85sj0cmqda0hf8g3y4qabs8j9j-helm-2.11.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: kubernetes-helm

Partial log (click to expand)

find: '/nix/store/kbxr5pr7s5b7r4z72x6lznw075mpmb5l-helm-2.11.0': No such file or directory
find: '/nix/store/kbxr5pr7s5b7r4z72x6lznw075mpmb5l-helm-2.11.0': No such file or directory
find: '/nix/store/kbxr5pr7s5b7r4z72x6lznw075mpmb5l-helm-2.11.0': No such file or directory
find: '/nix/store/kbxr5pr7s5b7r4z72x6lznw075mpmb5l-helm-2.11.0': No such file or directory
find: '/nix/store/kbxr5pr7s5b7r4z72x6lznw075mpmb5l-helm-2.11.0': No such file or directory
find: '/nix/store/kbxr5pr7s5b7r4z72x6lznw075mpmb5l-helm-2.11.0': No such file or directory
find: '/nix/store/kbxr5pr7s5b7r4z72x6lznw075mpmb5l-helm-2.11.0': No such file or directory
find: '/nix/store/kbxr5pr7s5b7r4z72x6lznw075mpmb5l-helm-2.11.0': No such file or directory
find: '/nix/store/kbxr5pr7s5b7r4z72x6lznw075mpmb5l-helm-2.11.0': No such file or directory
/nix/store/l74va0dsi78jfhf6lzbwc4z3i1n2amyv-helm-2.11.0-bin

@nlewo
Copy link
Member

nlewo commented Nov 22, 2018

Thanks!

@nlewo nlewo merged commit e3970df into NixOS:master Nov 22, 2018
@nlewo nlewo mentioned this pull request Nov 22, 2018
Closed
9 tasks
leahneukirchen added a commit to void-linux/void-packages that referenced this pull request May 3, 2019
@leahneukirchen
kubernetes-helm: force setting version
ba48b87 
Without this patch, the Helm client will think it is
&version.Version{SemVer:"v2.13", GitCommit:"", GitTreeState:""}
and install the Tiller image gcr.io/kubernetes-helm/tiller:v2.13 which
does not exist.

Adapted from NixOS/nixpkgs#50918
atweiden pushed a commit to atweiden/voidpkgs that referenced this pull request May 3, 2019
kubernetes-helm: force setting version
aae9be1 
Without this patch, the Helm client will think it is
&version.Version{SemVer:"v2.13", GitCommit:"", GitTreeState:""}
and install the Tiller image gcr.io/kubernetes-helm/tiller:v2.13 which
does not exist.

Adapted from NixOS/nixpkgs#50918

void-linux/void-packages@ba48b87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nightkr @FRidh @nlewo @GrahamcOfBorg