Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plata-theme: init at 0.4.9 #52425

Merged
merged 1 commit into from Dec 17, 2018
Merged

plata-theme: init at 0.4.9 #52425

merged 1 commit into from Dec 17, 2018

Conversation

tadfisher
Copy link
Contributor

Motivation for this change

Plata is a GTK+ theme based on Material Design Refresh. It was formerly known as Adapta 3.95.0, which I PR'd here: #47610

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 17, 2018

Could you locate it under pkgs/data/themes please?

And move the line in all-packages.nix in the ### DATA section

@tadfisher
Copy link
Contributor Author

@c0bw3b Moved, thanks!

@c0bw3b c0bw3b merged commit 6a80140 into NixOS:master Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tadfisher @c0bw3b @GrahamcOfBorg