Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rendersvg: init at 0.7.0 #52433

Closed
wants to merge 1 commit into from
Closed

rendersvg: init at 0.7.0 #52433

wants to merge 1 commit into from

Conversation

flosse
Copy link
Contributor

@flosse flosse commented Dec 17, 2018

Motivation for this change

rendersvg enables me to render SVG-Files without Inkscape :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member

aanderse commented Aug 4, 2019

@flosse are you able to address the comments above and continue with this PR?

@flosse flosse force-pushed the rendersvg branch 2 times, most recently from 80a8770 to 4af947b Compare August 4, 2019 20:51
@flosse flosse changed the title rendersvg: init at 0.4.0 rendersvg: init at 0.7.0 Aug 4, 2019
@flosse
Copy link
Contributor Author

flosse commented Aug 4, 2019

... also updated to v0.7.0

@aanderse
Copy link
Member

aanderse commented Aug 5, 2019

@flosse looks like issue with gdk_pixbuf. Also pkgconfig should have remained in nativeBuildInputs. If you need help don't hesitate to ask.

@flosse
Copy link
Contributor Author

flosse commented Aug 5, 2019

Also pkgconfig should have remained in nativeBuildInputs.

To be honest I have not idea what's the difference between nativeBuildInputs and buildInputs :-(

@aanderse
Copy link
Member

aanderse commented Aug 5, 2019

@flosse Yeah the documentation for nativeBuildInputs is horrible, in my opinion. Here is how it was explained to me, though:

Dependencies that are run during build should go to nativeBuildInputs, runtime dependencies go to buildInputs

So build system tools like cmake, pkgconfig, bison, flex, etc... should go in nativeBuildInputs. I hope that clarifies for you!

aanderse
aanderse requested changes Aug 5, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some comments I hope you will find helpful. I'm not overly familiar with rust but seeing as @fpletz had no complaints I'll assume everything I have not commented on is in good order.

pkgs/applications/graphics/rendersvg/default.nix
fetchFromGitHub,
rustPlatform,
pango,
gdk_pixbuf,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gdk_pixbuf -> gdk-pixbuf

pkgs/applications/graphics/rendersvg/default.nix
}:

rustPlatform.buildRustPackage rec {
name = "rendersvg-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use pname = "rendersvg"; as name = "${pname}-${version}"; is already implied.

pkgs/applications/graphics/rendersvg/default.nix

buildInputs = [
pango
gdk_pixbuf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gdk_pixbuf -> gdk-pixbuf

pkgs/applications/graphics/rendersvg/default.nix

meta = with stdenv.lib; {
description = "A SVG rendering application based on resvg";
homepage = https://github.com/RazrFalcon/resvg/tree/master/tools/rendersvg;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please quote.

pkgs/applications/graphics/rendersvg/default.nix
homepage = https://github.com/RazrFalcon/resvg/tree/master/tools/rendersvg;
license = with licenses; [ mpl20 ];
maintainers = with maintainers; [ flosse ];
platforms = [ "x86_64-linux" ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a quick glance at the site I would have thought this to be platforms.all.

@aanderse
Copy link
Member

@flosse do you currently have any time/motivation/ability to continue with this PR?

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@SuperSandro2000 SuperSandro2000 marked this pull request as draft November 28, 2020 04:33
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 28, 2020
@stale
Copy link

stale bot commented Jun 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2021
@Artturin Artturin closed this May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz left review comments

@aanderse aanderse aanderse requested changes

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) 9.needs: reporter feedback 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@flosse @aanderse @fpletz @GrahamcOfBorg @Artturin