Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boost169: init (at 1.69) #52426

Merged
merged 1 commit into from Dec 17, 2018
Merged

boost169: init (at 1.69) #52426

merged 1 commit into from Dec 17, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 17, 2018

Motivation for this change

https://www.boost.org/users/history/version_1_69_0.html

From a maintainer perspective, the visibility changes are welcome
(but also may cause problems at first).

However this doesn't change our default boost version
(currently at 1.67) so there's no breakage "yet" :).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa
Copy link
Member

boost162 and boost163 seem to be unused. Can they be removed?

@dtzWill
Copy link
Member Author

dtzWill commented Dec 17, 2018

boost162 and boost163 seem to be unused. Can they be removed?

Probably? Not sure if anyone has a reason to want them, which of course makes me inclined to suggest removing and see who complains :).

@fpletz fpletz merged commit 54d1529 into NixOS:master Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @markuskowa @fpletz @GrahamcOfBorg