Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundler: 1.17.1 -> 1.17.2 #52440

Merged
merged 1 commit into from Dec 20, 2018
Merged

bundler: 1.17.1 -> 1.17.2 #52440

merged 1 commit into from Dec 20, 2018

Conversation

alyssais
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
Copy link
Member Author

@GrahamcOfBorg eval

@zimbatm
Copy link
Member

zimbatm commented Dec 17, 2018

@alyssais do you want to take my place as a ruby maintainer? I don't use ruby that much these days and you have been doing a great job taking care of the regular upgrades.

@alyssais
Copy link
Member Author

Sure, happy to. Does that mean change CODEOWNERS, or are there maintainerss somewhere that need to be updated? (Or both?)

@zimbatm
Copy link
Member

zimbatm commented Dec 17, 2018

CODEOWNERS and maintainers in pkgs/development/ruby-modules/**/*.nix. /cc @manveru to give access to bundix as well (or move it to the nix-community org).

@manveru
Copy link
Contributor

manveru commented Dec 18, 2018

@zimbatm I invited @alyssais to collaborate on bundix. I'm also fine with moving it to nix-community if it has any benefits.

@zimbatm
Copy link
Member

zimbatm commented Dec 18, 2018

thanks @manveru! Technically you should have access to move the repo. I don't know if there are strict benefits. I would say that if you don't want to maintain the repo actively then it probably makes sense to move it.

@alyssais
Copy link
Member Author

I think having it in an org means that more than one person can administer it, whereas if it's attached to a user, only they can. So having it in an org reduces bus factor.

@alyssais alyssais merged commit dafdadd into NixOS:master Dec 20, 2018
@alyssais alyssais deleted the bundler branch December 20, 2018 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants