Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

easystroke: init at unstable-2016-07-05 #52424

Closed
wants to merge 1 commit into from
Closed

easystroke: init at unstable-2016-07-05 #52424

wants to merge 1 commit into from

Conversation

ivan
Copy link
Member

@ivan ivan commented Dec 17, 2018

Motivation for this change

easystroke allows binding mouse gestures to commands. Upstream development has apparently ceased, but the program is very useful and, as far as I know, there is no equivalent alternative.

@revast investigated which patches should be applied and I've closely followed the list of patches in the new build instructions.

I have tested the resulting binary and it seems to work fine with my existing configuration and without an existing configuration.

This PR obsoletes #37353. I have fixed the things @andir mentioned in the review.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ivan
Copy link
Member Author

ivan commented Dec 17, 2018

Updated to use dbus-glib instead of dbus_glib to hopefully make grahamcofborg happy.

@revast
Copy link

revast commented Dec 17, 2018

nice! Thanks for packaging!

jtojnar
jtojnar reviewed Dec 17, 2018
View reviewed changes
pkgs/applications/misc/easystroke/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/easystroke/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/easystroke/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/easystroke/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/easystroke/default.nix Outdated Show resolved Hide resolved
@ivan
Copy link
Member Author

ivan commented Dec 17, 2018

Thanks for the review! I think I fixed everything mentioned. I was also required to add two name = s for the patches that now have a & in their URLs.

I also noticed that the man page wasn't being installed, so I fixed that as well.

@ivan ivan force-pushed the add-easystroke branch 2 times, most recently from 3750564 to 2576bf2 Compare January 13, 2019 09:12
@ivan
easystroke: init at unstable-2016-07-05
14bf75f 
This commit is based on work by Andreas Schaefer in
NixOS#37353
@ivan
Copy link
Member Author

ivan commented Jan 13, 2019

Updated to add knownVulnerabilities (not sure if even suitable for inclusion now?), then updated to replace xorg.inputproto (now gone) with xorg.xorgproto.

@jtojnar
Copy link
Contributor

jtojnar commented Jan 13, 2019

We can still merge this as long as it is useful to someone.

Though it would be nice if the people interested in this settled on a fork and merged the patches there. Or maybe try to contact the author via e-mail.

@winpat
Copy link
Member

winpat commented May 6, 2019

@jtojnar I would be very much interested in this.

@ivan
Copy link
Member Author

ivan commented May 6, 2019

I am currently testing my fork https://github.com/ludios/easystroke to see if the rare Xorg crash (when starting a stroke) is fixed by this change, and I will update this PR if it does.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/26

@timokau timokau mentioned this pull request Jun 27, 2019
Closed
8 tasks
@ivan
Copy link
Member Author

ivan commented Jul 17, 2019

I wasn't able to resolve the occasional Xorg crash-on-stroke issue in my fork, and while I continue to use easystroke, I suggest avoiding it unless someone fixes the crasher. Anyone else is welcome to pick this up if they wish.

@ivan ivan closed this Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
2.status: work-in-progress 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ivan @revast @jtojnar @winpat @nixos-discourse @timokau @GrahamcOfBorg