Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icu63: init at 63.1 #52416

Merged
merged 1 commit into from Dec 21, 2018
Merged

icu63: init at 63.1 #52416

merged 1 commit into from Dec 21, 2018

Conversation

alyssais
Copy link
Member

Motivation for this change

Next version of Firefox will require this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

It's highly likely that we don't need to be packaging so many versions of this, but as far as I can tell, last time it was planned to test whether the default could be bumped (#35294), that test never actually happened.

Let's get this added, and then check on staging what a bump does.

@samueldr
Copy link
Member

@GrahamcOfBorg build pkgsi686Linux.icu63

@alyssais
Copy link
Member Author

@GrahamcOfBorg build pkgsi686Linux.icu63

@alyssais
Copy link
Member Author

@GrahamcOfBorg build pkgsi686Linux.icu63

@alyssais alyssais merged commit a2eed09 into NixOS:master Dec 21, 2018
@alyssais alyssais mentioned this pull request Dec 21, 2018
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alyssais @samueldr @GrahamcOfBorg