Oh, looks like the Insiders build works now, though the stable build is now broken, ldd seems to be showing everything got patched and code --verbose shows nothing. Gonna look at it again when I have more time.

Actually, I think I just botched both.

Seems like the executable works? Though the renderer and extHost don't start up at all, which basically screws everything.

Alright it seems like it might be due to an RPATH issue since it seems to use the libgcc_s.so.1 from glibc over gcc. The interpreter looks to be fine. Any idea on how to put gcc on a higher priority than glibc for autoPatchelfHook? Tried adding gcc as a build input and manually patching it afterwards with patchelf --set-rpath "${lib.makeLibraryPath[gcc]}:$(patchelf --print-rpath $out/lib/vscode/${executableName})".

From old to autoPatchelfHook, libgcc_s.so.1 => /nix/store/x6inizi5ahlyhqxxwv1rvn05a25icarq-gcc-7.3.0-lib/lib/libgcc_s.so.1 (0x00007f70c248b000) to libgcc_s.so.1 => /nix/store/xdsjx0gba4id3yyqxv66bxnm2sqixkjj-glibc-2.27/lib/libgcc_s.so.1 (0x00007f5b88498000).

Used gcc-unwrapped but still the same problem, though if I keep the patchelf used originally for the executable everything works fine.

@aszlig might know

Looks like it's a problem with RPATH since patching in systemd and fontconfig into the RPATH allows it to work. autoPatchelfHook doesn't do it automatically since it doesn't even seem to be required though it does exist when I run ldd. libsystemd.so.0 only seems to be needed somewhere after the patching.

original ldd output: https://pastebin.com/raw/Px8PAbsT

after build: https://pastebin.com/raw/ugiykiWU

The interpreter looks to be fine. Any idea on how to put gcc on a higher priority than glibc for autoPatchelfHook?

There is no direct way to assign priorities, but you can give a dependency precedence over others by using addAutoPatchelfSearchPath "$gcclibs" before postFixup.

#55362 needs this.

@Mic92 Any other reservations about this?

@eadwu I can merge this if you can verify 3513063 doesn't break anything for you.

Works fine for me, also a crude test of find -type f -executable -exec ldd "{}" \; shows all dependencies are found.