Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildkit: init at v0.4.0 #52441

Merged
merged 1 commit into from Aug 6, 2019
Merged

buildkit: init at v0.4.0 #52441

merged 1 commit into from Aug 6, 2019

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Dec 17, 2018 •
edited

Signed-off-by: Vincent Demeester vincent@sbr.pm

Motivation for this change

BuildKit is a toolkit for converting source code to build artifacts in an efficient, expressive and repeatable manner.

buildkit is also used inside the docker daemon since 18.06 (experimental) and 18.09 (stable).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vdemeester
Copy link
Member Author

ping @Mic92

@marsam
Copy link
Contributor

marsam commented Feb 13, 2019

ping @worldofpeace

nlewo
nlewo previously requested changes Feb 13, 2019
View reviewed changes
pkgs/development/tools/buildkit/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/buildkit/default.nix Outdated Show resolved Hide resolved
@vdemeester
Copy link
Member Author

@nlewo @worldofpeace updated at last 👼

@worldofpeace worldofpeace dismissed nlewo’s stale review February 28, 2019 18:25

resolved by author

worldofpeace
worldofpeace suggested changes Feb 28, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure the proper way to test this here.
Seeing that it depends on either a runc or containerd backend.

Additionally it's using a version placeholder 0.0.0+unknown in the help menus.
Perhaps there's a simple way to inject this.

@vdemeester
buildkit: init at v0.4.0
9934f53 
compile `builtkitd` only on Linux, `buildkitctl` on all envs.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@vdemeester vdemeester changed the title buildkit: init at v0.3.3 buildkit: init at v0.4.0 Mar 14, 2019
@aanderse
Copy link
Member

aanderse commented Aug 4, 2019

ping (triage)

@marsam marsam merged commit 0651ab5 into NixOS:master Aug 6, 2019
@marsam
Copy link
Contributor

marsam commented Aug 6, 2019

I'm going ahead and merge

Seeing that it depends on either a runc or containerd backend.

The server buildkitd requires runc available in PATH, but that should not stop using the client buildctl independently

Additionally it's using a version placeholder 0.0.0+unknown

I'm going to address this in another PR

@vdemeester vdemeester deleted the init-buildkit branch August 6, 2019 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

@marsam marsam marsam approved these changes

@nlewo nlewo nlewo left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vdemeester @marsam @aanderse @nlewo @worldofpeace @GrahamcOfBorg