Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gdb: cross compilation requires build gcc #52442

Closed
wants to merge 1 commit into from
Closed

gdb: cross compilation requires build gcc #52442

wants to merge 1 commit into from

Conversation

bennofs
Copy link
Contributor

@bennofs bennofs commented Dec 17, 2018

Motivation for this change

Without this, gdb doesn't cross compile correctly. See https://gist.github.com/nschoe/171dbcff106d55ad69d9a2c6056d388f for build failure log.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bennofs bennofs changed the base branch from master to staging December 17, 2018 15:34
@bennofs
Copy link
Contributor Author

bennofs commented Dec 17, 2018

changed the base to staging since it has >500 rebuilds

@bennofs
Copy link
Contributor Author

bennofs commented Dec 17, 2018

Oh, didn't see that this was already fixed in staging!

@bennofs bennofs closed this Dec 17, 2018
@bennofs bennofs deleted the fix-gdb-cross branch December 17, 2018 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bennofs @GrahamcOfBorg