New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python37: Remove references to openssl.dev #51775
Conversation
be4b55c
to
c612ac5
Compare
@@ -145,7 +145,11 @@ in stdenv.mkDerivation { | |||
# some $TMPDIR references to improve binary reproducibility. | |||
# Note that the .pyc file of _sysconfigdata.py should be regenerated! | |||
for i in $out/lib/python${majorVersion}/_sysconfigdata*.py $out/lib/python${majorVersion}/config-${majorVersion}m*/Makefile; do | |||
sed -i $i -e "s|-I/nix/store/[^ ']*||g" -e "s|-L/nix/store/[^ ']*||g" -e "s|$TMPDIR|/no-such-path|g" | |||
sed -i $i \ | |||
-e "s|-I/nix/store/[^ ']*||g" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is an existing problem, but we shouldn't assume that the Nix store is at /nix/store
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIX_BUILD_TOP
is the best thing to use instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some digging, and it looks like nuke-references
uses $NIX_STORE
; I updated the PR to use that instead!
c612ac5
to
cdb6673
Compare
(triage) anything blocking this from being merged? @dezgeg is your comment resolved? |
conflicts with #51724 |
Thanks. Pushed 2526f9f to staging. |
Motivation for this change
Updates the
postInstall
to also strip the configure flag that contains--with-openssl=/nix/store/...
, which results in a reference toopenssl.dev
Fixes #51465
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)cc @FRidh