[18.09] rust-cbindgen: 0.6.2 -> 0.6.7 #51805
Conversation
|
Maybe make a separate attribute |
There is only one consumer of that package and that is firefox. Do you still think it would be a benefit to someone to keep the old version around? At the time of the original commit I checked the changelog and it did break a bit of older configurations. If there are users outside of nixpkgs those would benefit from it. While I usually am all for stability on a stable branch I am not sure of the additional value. Most people would probably have it in their local Cargo.toml anyway?!? I am not set on an opinon. Happy to add another attribute if you really think it is required. |
|
@andir |
after feedback from @veprbl in NixOS#51805 I added this as another package which can be used for the 18.09 firefox builds. (cherry picked from commit f1ee26b)
andir
force-pushed
the
18.09/cbindgen
branch
from
da289c6
to
75614f2
Compare
|
@veprbl I updated the commit to introduce another attribute in all-packages.nix instead. Please let me know if this looks good to you. Feel free to merge :-) As soon as we settled on this I can start the firefox backports. |
|
@GrahamcOfBorg eval |
GrahamcOfBorg
added
8.has: package (new)
10.rebuild-darwin: 0
and removed
10.rebuild-darwin: 1-10
labels
|
@GrahamcOfBorg build rust-cbindgen_0_6_7 |
This update is required for the upcoming firefox release. We can defer merging until the firefox bump has arrived since it provides little value and causes useless rebuilds.
I did successfully rebuild the stable firefox and the latest ffx beta release with this bump.