Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssl_1_1: Add "doc" output to contain HTML documentation #51781

Merged
merged 1 commit into from Dec 10, 2018
Merged

openssl_1_1: Add "doc" output to contain HTML documentation #51781

merged 1 commit into from Dec 10, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Dec 9, 2018

This prevents cluttering up openssl_1_1.out with many megabytes of
documentation.

Fixes #51659

same as #51776 but on master branch.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andrew-d @Mic92
openssl_1_1: Add "doc" output to contain HTML documentation
14087ab 
This prevents cluttering up openssl_1_1.out with many megabytes of
documentation.

Fixes NixOS#51659
@Mic92
Copy link
Member Author

Mic92 commented Dec 9, 2018

@GrahamcOfBorg build openssl

@Mic92 Mic92 mentioned this pull request Dec 9, 2018
Closed
10 tasks
@andrew-d
Copy link
Contributor

andrew-d commented Dec 9, 2018

@Mic92 - You probably want @GrahamcOfBorg build openssl_1_1?

@vcunat
Copy link
Member

vcunat commented Dec 9, 2018

It did so automatically anyway. Note that Borg's comments appear in the "checks" tab since recently.

@andrew-d
Copy link
Contributor

andrew-d commented Dec 9, 2018

Oh I didn't know that - thanks!

@Mic92 Mic92 merged commit 48e49d0 into NixOS:master Dec 10, 2018
@Mic92 Mic92 deleted the openssl-11-docs branch December 10, 2018 00:43
@andrew-d
Copy link
Contributor

@Mic92 - Thanks for rebasing this on master! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mic92 @andrew-d @vcunat @GrahamcOfBorg